Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase manager crash in fees test #5150

Closed
Tracked by #4998
alexghr opened this issue Mar 12, 2024 · 0 comments · Fixed by #5156
Closed
Tracked by #4998

Phase manager crash in fees test #5150

alexghr opened this issue Mar 12, 2024 · 0 comments · Fixed by #5156
Assignees

Comments

@alexghr
Copy link
Contributor

alexghr commented Mar 12, 2024

Change the e2e fees test "pay privately with banana via FPC" to do a transfer instead of minting. The test will crash with

 Cannot transition to setup phase

      88 |   ): AbstractPhaseManager | undefined {
      89 |     if (output.needsSetup) {
    > 90 |       throw new CannotTransitionToSetupError();
         |             ^
      91 |     } else if (output.needsAppLogic) {
      92 |       if (currentPhaseManager.phase === PublicKernelPhase.APP_LOGIC) {
      93 |         throw new PhaseDidNotChangeError(currentPhaseManager.phase);

      at Function.phaseFromOutput (../../sequencer-client/src/sequencer/phase_manager_factory.ts:90:13)
      at PublicProcessor.process (../../sequencer-client/src/sequencer/public_processor.ts:118:39)
      at async AztecNodeService.simulatePublicCalls (../../aztec-node/src/aztec-node/server.ts:640:39)
      at async PXEService._PXEService_simulatePublicCalls (../../pxe/src/pxe_service/pxe_service.ts:579:7)
      at ../async /home/ubuntu/host/aztec-packages/yarn-project/pxe/src/pxe_service/pxe_service.ts:399:9
      at ../async /home/ubuntu/host/aztec-packages/yarn-project/foundation/src/fifo/serial_queue.ts:63:23
      at async MemoryFifo.process (../../foundation/src/fifo/memory_fifo.ts:112:9)
@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 12, 2024
@alexghr alexghr self-assigned this Mar 12, 2024
@alexghr alexghr moved this from Todo to In Progress in A3 Mar 13, 2024
@alexghr alexghr moved this from In Progress to In Review in A3 Mar 13, 2024
alexghr added a commit that referenced this issue Mar 13, 2024
…5156)

This PR fixes an issue where the phase manager was incorrectly
extracting setup and teardown enqueued public function calls when there
was no app logic in between them.

Fix #5150 
Stacked on top of #5129

Co-authored-by: Mitchell Tracy <mitchell@aztecprotocol.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant