Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(PortalAddress): Purge the portal address and use storage instead #5836

Closed
Tracked by #4492
LHerskind opened this issue Apr 18, 2024 · 0 comments · Fixed by #5842
Closed
Tracked by #4492

refactor(PortalAddress): Purge the portal address and use storage instead #5836

LHerskind opened this issue Apr 18, 2024 · 0 comments · Fixed by #5842
Assignees
@LHerskind

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Apr 18, 2024 •
edited
Loading

The portal address that is available in the context and specified as an option on the deployment could be replaced by using simple storage instead. This simplifies the model slightly as we don't need to deal with this special value.

Also it reduces the amount of data that is published for contract that don't have storage based portal addresses.

It was made like this way back in the days before we knew how to nicely do a shared mutable, so lets clean up now that we can.
This was referenced Apr 18, 2024
Closed
Merged
Merged
@LHerskind LHerskind self-assigned this Apr 18, 2024
LHerskind added a commit that referenced this issue Apr 22, 2024
@LHerskind
refactor: purging portal addresses (#5842)
4faccad 
Fixes #5836. 

Purges the portal addresses from its priveleged storage position and
throws it into the darkness of "normal" storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: purging portal addresses AztecProtocol/aztec-packages
1 participant
@LHerskind