Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle zero public keys hash #5862

Closed
Tracked by #5759
benesjan opened this issue Apr 19, 2024 · 2 comments
Closed
Tracked by #5759

Handle zero public keys hash #5862

benesjan opened this issue Apr 19, 2024 · 2 comments
Assignees
@benesjan @LHerskind
Labels
S-needs-discussion Status: Still needs more discussion before work can start.

Comments

@benesjan
Copy link
Contributor

benesjan commented Apr 19, 2024 •
edited
Loading

See Lasse's comment on my PR for context.

Look for "TODO(#5862)" in the codebase.
@benesjan benesjan mentioned this issue Apr 19, 2024
Closed
@benesjan benesjan added the S-needs-discussion Status: Still needs more discussion before work can start. label Apr 19, 2024
@LHerskind
Copy link
Contributor

For many of the derivation and decryption functions 0 will be a breaking value so it is simply reject in many cases, the remaining will for now be up to the application unless we figure that it is sufficiently painful to deal with at a later point, for example like the address(0) of signature recovery in solidity .

@LHerskind LHerskind mentioned this issue May 1, 2024
Open
@benesjan
Copy link
Contributor Author

benesjan commented Aug 9, 2024

Outdated now so I am closing it

@benesjan benesjan closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

@LHerskind LHerskind

Labels
S-needs-discussion Status: Still needs more discussion before work can start.
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benesjan @LHerskind