Remove FieldNote #5932
Assignees
Comments
nventuro
added a commit
that referenced
this issue
Apr 23, 2024
`TestContract` was its sole user, so I just created `TestNote` inside that crate to replace it. Closes #5932
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this issue
Apr 24, 2024
`TestContract` was its sole user, so I just created `TestNote` inside that crate to replace it. Closes AztecProtocol/aztec-packages#5932
superstar0402
added a commit
to superstar0402/aztec-nr
that referenced
this issue
Aug 16, 2024
`TestContract` was its sole user, so I just created `TestNote` inside that crate to replace it. Closes AztecProtocol/aztec-packages#5932
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FieldNoteis not a 'real' note type in that it's an incomplete implementation of a barebones note not meant to be used in any real application, and it only exists for testing purposes. However its name leads to confusing as it makes users go 'oh this is a note that contains a field, neat', when they should really be usingValueNote. I'd advise against renamingValueNoteat this stage to minimize churn.We should be able to mostly get rid of
FieldNote, and create aTestNotetype in places where we can't (e.g.TestContract) as part of that package, instead of it being its own seemingly legit package likeValueNoteorAddressNote.The text was updated successfully, but these errors were encountered: