feat(avm-simulator): consider previous pending nullifiers across enqueued calls #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @fcarreiro and the rest of your teammates on |
fcarreiro
force-pushed
the
fc/avm-storage-across-enqueued-calls
branch
from
569386b
to
d966123
Compare
fcarreiro
force-pushed
the
fc/avm-nullifiers-across-enqueued-calls
branch
from
6753ba3
to
78fdfc8
Compare
fcarreiro
force-pushed
the
fc/avm-storage-across-enqueued-calls
branch
from
d966123
to
f29b328
Compare
fcarreiro
force-pushed
the
fc/avm-nullifiers-across-enqueued-calls
branch
from
78fdfc8
to
f1afce6
Compare
dbanks12
reviewed
May 3, 2024
Comment on lines
+75
to
+84
| for (const nullifier of executionContext.pendingNullifiers) { | ||
| worldStateJournal.nullifiers.cache.appendSiloed(nullifier.value); | ||
| } |
There was a problem hiding this comment.
This is probably fine for now.... But if we plan to use this long-term (as opposed to having another layer of caching like the WorldStatePublicDB), maybe this should be a constructor argument to the state manager?
fcarreiro
force-pushed
the
fc/avm-storage-across-enqueued-calls
branch
from
f29b328
to
b9acabf
Compare
fcarreiro
force-pushed
the
fc/avm-nullifiers-across-enqueued-calls
branch
from
f1afce6
to
6212576
Compare
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
fcarreiro
force-pushed
the
fc/avm-storage-across-enqueued-calls
branch
from
62043e0
to
46c74f8
Compare
fcarreiro
force-pushed
the
fc/avm-nullifiers-across-enqueued-calls
branch
from
6212576
to
09a6736
Compare
Merge activity
|
This was referenced May 7, 2024
TomAFrench
added a commit
that referenced
this pull request
May 8, 2024
* master: (25 commits) fix: Enable client proof tests (#6249) chore: update cspell for abi demonomorphizer (#6258) feat(aztec-nr): add 'with_gas()' function to avm call interface (#6256) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: Pw/update merge check (#6201) chore(master): Release 0.37.1 (#6148) fix: Cl/split out e2e tests (#6242) feat: Typings generator with generics (#6235) chore(ci): fix restarts with fresh spot, acir test fixes, non-mandatory benches (#6226) chore: misc AVM migration prep changes (#6253) feat!: AES blackbox (#6016) chore(docs): Fix some typos in specs of private kernel initial (#6224) chore(aztec-macros): avm function return types are auto tagged as `pub` (#6250) chore(aztec-nr): create a 'with_selector' version of `emit_unencrypted_log` in avm context (#6248) fix: registering PublicDataWitness in JsonRpcServer (#6243) feat: Sync from noir (#6234) feat(avm-simulator): consider previous pending nullifiers across enqueued calls (#6188) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.