chore: misc AVM migration prep changes #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
force-pushed
the
db/avm-migration-prep
branch
from
ba0e191
to
3ed5b90
Compare
dbanks12
changed the title
dbanks12
commented
May 7, 2024
Comment on lines
-434
to
447
| let registry_private_getter: SharedMutablePrivateGetter<Field, 5> = SharedMutablePrivateGetter::new(context, AztecAddress::from_field(CANONICAL_KEY_REGISTRY_ADDRESS), derived_slot); | ||
| let registry_private_getter: SharedMutablePrivateGetter<Field, 5> = SharedMutablePrivateGetter::new( | ||
| context, | ||
| AztecAddress::from_field(CANONICAL_KEY_REGISTRY_ADDRESS), | ||
| derived_slot | ||
| ); | ||
| registry_private_getter.get_current_value_in_private() | ||
| } | ||
|
|
||
| #[aztec(private)] | ||
| fn test_nullifier_key_freshness( | ||
| address: AztecAddress, | ||
| public_nullifying_key: GrumpkinPoint, | ||
| ) { | ||
| fn test_nullifier_key_freshness(address: AztecAddress, public_nullifying_key: GrumpkinPoint) { | ||
| assert_eq(get_npk_m(&mut context, address), public_nullifying_key); | ||
| } |
There was a problem hiding this comment.
Auto-formatting by LSP
fcarreiro
reviewed
May 7, 2024
| expect(revertReason?.message).toMatch(`Invalid header hash`); | ||
| }); | ||
| }); | ||
| // TODO(4840): add AVM opcodes for getting header (members) |
There was a problem hiding this comment.
Would a describe.skip work?
Otherwise, /* */ might be less disruptive?
(I don't feel strongly on any changes tho)
There was a problem hiding this comment.
Good point! I didn't think .skip would work, but I was thinking of e2e stuff when we call functions by name, vs here we are looking for a string in the artifact. I'll do .skip :)
dbanks12
force-pushed
the
db/avm-migration-prep
branch
from
3ed5b90
to
7948274
Compare
fcarreiro
approved these changes
May 7, 2024
…en't yet supported by AVM
dbanks12
force-pushed
the
db/avm-migration-prep
branch
from
7948274
to
caec1d8
Compare
This was referenced May 7, 2024
TomAFrench
added a commit
that referenced
this pull request
May 8, 2024
* master: (25 commits) fix: Enable client proof tests (#6249) chore: update cspell for abi demonomorphizer (#6258) feat(aztec-nr): add 'with_gas()' function to avm call interface (#6256) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: Pw/update merge check (#6201) chore(master): Release 0.37.1 (#6148) fix: Cl/split out e2e tests (#6242) feat: Typings generator with generics (#6235) chore(ci): fix restarts with fresh spot, acir test fixes, non-mandatory benches (#6226) chore: misc AVM migration prep changes (#6253) feat!: AES blackbox (#6016) chore(docs): Fix some typos in specs of private kernel initial (#6224) chore(aztec-macros): avm function return types are auto tagged as `pub` (#6250) chore(aztec-nr): create a 'with_selector' version of `emit_unencrypted_log` in avm context (#6248) fix: registering PublicDataWitness in JsonRpcServer (#6243) feat: Sync from noir (#6234) feat(avm-simulator): consider previous pending nullifiers across enqueued calls (#6188) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of debug and header oracles in contracts which aren't yet supported by AVM. Transpile all noir-contracts instead of only those prefixed with
avm_(functions are checked anyway to see if they are tagged public-vm before transpilation).