Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix restarts with fresh spot, acir test fixes, non-mandatory benches #6226

Merged
merged 14 commits into from
May 7, 2024

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented May 6, 2024

No description provided.

@ludamad ludamad changed the title chore(ci): WIP chore(ci): fix restarts with fresh spot, acir test fixes May 7, 2024
@ludamad ludamad changed the title chore(ci): fix restarts with fresh spot, acir test fixes chore(ci): fix restarts with fresh spot, acir test fixes, non-mandatory benches May 7, 2024
Comment on lines +179 to +181
# Prepare our exact dependency formula, this avoids problems with copied empty folders or build artifacts
RUN rm -rf .earthly-staging && mkdir -p .earthly-staging
RUN cp --parents $(git ls-files "noir-repo/test_programs/*.toml" "noir-repo/test_programs/*.nr" "noir-repo/test_programs/rebuild.sh") .earthly-staging
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this the cause for the different output of acir generation? How come?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there was actually different output, I think Phil's artifacts were copying into earthly, the thing he mentioned building wasn't built at all by the build hm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that was the issue, shouldn't we fix it by having an earthlyignore that follows the gitignore, leaving these artifacts out?

.github/workflows/setup-runner.yml Outdated Show resolved Hide resolved
ludamad and others added 4 commits May 7, 2024 15:01
@ludamad ludamad merged commit adb7f37 into master May 7, 2024
58 checks passed
@ludamad ludamad deleted the ad/ci-misc branch May 7, 2024 20:12
TomAFrench added a commit that referenced this pull request May 8, 2024
* master: (25 commits)
  fix: Enable client proof tests (#6249)
  chore: update cspell for abi demonomorphizer (#6258)
  feat(aztec-nr): add 'with_gas()' function to avm call interface (#6256)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  fix: Pw/update merge check (#6201)
  chore(master): Release 0.37.1 (#6148)
  fix: Cl/split out e2e tests (#6242)
  feat: Typings generator with generics (#6235)
  chore(ci): fix restarts with fresh spot, acir test fixes, non-mandatory benches (#6226)
  chore: misc AVM migration prep changes (#6253)
  feat!: AES blackbox (#6016)
  chore(docs): Fix some typos in specs of private kernel initial (#6224)
  chore(aztec-macros): avm function return types are auto tagged as `pub` (#6250)
  chore(aztec-nr): create a 'with_selector' version of `emit_unencrypted_log` in avm context (#6248)
  fix: registering PublicDataWitness in JsonRpcServer (#6243)
  feat: Sync from noir (#6234)
  feat(avm-simulator): consider previous pending nullifiers across enqueued calls (#6188)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants