fix: Asset struct serialization does not match Noir internal serialization

[dbanks12]

No description provided.

[dbanks12]

• fix: Asset struct serialization does not match Noir internal serialization #6494 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dbanks12 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_witness_generation_time_in_ms (public-kernel-tail): 645 (+16%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	740	740	740
l1_rollup_calldata_gas	6,680	6,692	6,692
l1_rollup_execution_gas	586,865	586,877	586,877
l2_block_processing_time_in_ms	1,614	6,048	11,982
l2_block_building_time_in_ms	27,004 (+1%)	105,229	208,624
l2_block_rollup_simulation_time_in_ms	26,820 (+1%)	104,584	207,208
l2_block_public_tx_process_time_in_ms	12,016 (+1%)	50,822	101,852

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	18,021	33,498
node_database_size_in_bytes	21,409,872	38,010,960
pxe_database_size_in_bytes	29,868	59,425

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	protocol_circuit_simulation_time_in_ms	protocol_circuit_witness_generation_time_in_ms	protocol_circuit_proving_time_in_ms	protocol_circuit_input_size_in_bytes	protocol_circuit_output_size_in_bytes	protocol_circuit_proof_size_in_bytes	protocol_circuit_num_public_inputs	protocol_circuit_size_in_gates
private-kernel-init	142 (+1%)	2,600	21,749 (+4%)	19,396	46,118	62,400	1,883	1,048,576
private-kernel-inner	415	3,643 (-4%)	37,939	72,583	46,118	62,400	1,883	2,097,152
private-kernel-reset	674	4,384	45,165	219,992	46,118	62,400	1,883	2,097,152
private-kernel-tail	442	4,435	36,708 (-1%)	70,968	64,320	10,656	266	2,097,152
base-parity	8.13 (-1%)	1,069 (+12%)	3,549 (+6%)	128	64.0	2,208	2.00	131,072
root-parity	51.1	124 (-2%)	39,803 (+2%)	27,064	64.0	2,720	18.0	2,097,152
base-rollup	826	4,878 (-9%)	42,837	111,126	925	3,104	30.0	2,097,152
root-rollup	72.4	173 (+3%)	8,139	11,454	789	3,424	40.0	524,288
public-kernel-app-logic	155	241 (-11%)	746 (+15%)	78,387	68,775	90,432	2,759	4,096
public-kernel-tail	533	⚠️ 645 (+16%)	839 (-3%)	184,419	7,723	10,144	250	512
public-kernel-setup	133 (+3%)	324 (-7%)	757 (+1%)	110,522	68,775	90,432	2,759	4,096
public-kernel-teardown	137	402 (+10%)	903 (+2%)	114,417	68,775	90,432	2,759	4,096
merge-rollup	6.79 (+1%)	94.0 (+9%)	1,496 (-4%)	2,696	925	3,104	30.0	65,536
private-kernel-tail-to-public	N/A	8,956 (-1%)	42,777	N/A	N/A	90,944	2,775	2,097,152

Stats on running time collected for app circuits

Function	app_circuit_proof_size_in_bytes	app_circuit_proving_time_in_ms	app_circuit_size_in_gates	app_circuit_num_public_inputs
SchnorrAccount:entrypoint	13,600	45,590	2,097,152	358
Test:emit_nullifier	13,600	2,278 (-1%)	65,536	358
FPC:fee_entrypoint_public	13,600	13,157 (-2%)	524,288	358
Token:transfer	13,600	43,506 (+1%)	2,097,152	358
FPC:fee_entrypoint_private	13,600	11,014 (-1%)	524,288	358
Token:unshield	13,600	33,547	2,097,152	358
SchnorrAccount:spend_private_authwit	13,600	2,591 (+1%)	131,072	358

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	13.1	21.3	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.769	0.658	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	61.7 (-1%)	96.7	317 (+1%)	607 (-1%)	1,191	2,359	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.632 (-1%)	0.598	0.576 (+1%)	0.568 (-1%)	0.565	0.564	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	73.6 (-1%)	144 (+1%)	455 (+1%)	894	1,772	3,527	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	106	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.644 (-1%)	0.646	0.619 (+1%)	0.617	0.614	0.615	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	80.7
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	108
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.710

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	68,448	668,029

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	27,766	3,064	91,159

Metric	0 public data writes	1 public data writes	2 public data writes	4 public data writes	8 public data writes
tx_sequencer_processing_time_ms	836 (+3%)	1,558	1,273 (-4%)	2,130	1,328 (+1%)