feat: Update the encrypted note log format

[LHerskind]

Fixes #5901.

Uses the new format to match the keys and logs spec. The current implementation here is still using a typescript implementation to encrypt the data, mainly using the new flow.

The intention is that #6408 and #1139 can be addresses separately and than we can just replace the import to use the constrained version instead of the oracle at that point.

Note, that the outgoing logs are currently less than meaningful, as some of the infrastructure is not yet in place to handle those nicely, see #6410 for more on that.

What was called the encrypted_log_payload in #6348 have been moved into the l1_payload, to better integrate with the rest of the setup.

[LHerskind]

• feat: constrain note encryption #6432
• feat: Update the encrypted note log format #6411 👈
• feat: full encryption and decryption of log in ts #6348
• feat: add encrypted log outgoing body #6334
• refactor: cleanup the encrypted log incoming body #6325
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[benesjan]

Feel free to merge once you address my comments

[benesjan]

these numbers seem a bit magical 🤣

Can you add comment what they corrspond to?

[LHerskind]

It states just above that it is the exact same way as for the note, so thought I could get away with it 😆

[benesjan]

Ser, you expect me to remember what was 4 lines ago?

Jk, feel free to ape it in then

[benesjan]

Why don't you throw the error here? Would be unpleasant to randomly get undefined behavior in some e2e test when calling this.

And feels like w should track this with an issue.

[LHerskind]

The note processor was made to expect "undefined" instead of a throw. They are using it for the case it is unable to return, so was done to keep the pr small.

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_witness_generation_time_in_ms (base-parity): 227 (-58%)
• protocol_circuit_witness_generation_time_in_ms (public-kernel-teardown): 384 (-17%)
• protocol_circuit_witness_generation_time_in_ms (public-kernel-tail): 920 (+25%)
• protocol_circuit_witness_generation_time_in_ms (merge-rollup): 89.2 (-43%)
• protocol_circuit_proving_time_in_ms (public-kernel-teardown): 945 (-16%)
• protocol_circuit_proving_time_in_ms (merge-rollup): 1,570 (-33%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	740	740	740
l1_rollup_calldata_gas	6,692	6,692	6,692
l1_rollup_execution_gas	586,877	586,877	586,877
l2_block_processing_time_in_ms	1,616 (+1%)	6,062	12,028
l2_block_building_time_in_ms	35,431 (+1%)	139,205 (+1%)	278,876 (+1%)
l2_block_rollup_simulation_time_in_ms	35,212 (+1%)	138,420 (+1%)	277,272 (+1%)
l2_block_public_tx_process_time_in_ms	16,668	70,909 (+1%)	144,463 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	18,586 (+5%)	33,803 (+1%)
node_database_size_in_bytes	21,393,488	38,133,840
pxe_database_size_in_bytes	29,868	59,425

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	protocol_circuit_simulation_time_in_ms	protocol_circuit_witness_generation_time_in_ms	protocol_circuit_proving_time_in_ms	protocol_circuit_input_size_in_bytes	protocol_circuit_output_size_in_bytes	protocol_circuit_proof_size_in_bytes	protocol_circuit_num_public_inputs	protocol_circuit_size_in_gates
private-kernel-init	164 (+1%)	3,605 (+1%)	21,873 (-6%)	20,412	62,374	85,376	2,601	1,048,576
private-kernel-inner	538 (+1%)	4,351 (+1%)	45,558	89,855	62,374	85,376	2,601	2,097,152
private-kernel-reset	1,004 (+1%)	6,481	88,409	330,808	62,374	85,376	2,601	4,194,304
private-kernel-tail	536 (+1%)	4,941 (-1%)	39,286 (+1%)	87,224	79,333	10,656	266	2,097,152
base-parity	8.27 (+1%)	⚠️ 227 (-58%)	4,250 (+7%)	128	64.0	2,208	2.00	131,072
root-parity	51.9 (+2%)	129 (-15%)	39,417 (+3%)	27,064	64.0	2,720	18.0	2,097,152
base-rollup	923 (+1%)	5,039 (+10%)	43,134 (-1%)	111,126	925	3,104	30.0	2,097,152
root-rollup	72.9	173 (+2%)	8,326	11,454	789	3,424	40.0	524,288
public-kernel-app-logic	196 (+2%)	374 (-15%)	1,128 (+4%)	96,791	84,967	113,344	3,475	4,096
public-kernel-tail	899 (+1%)	⚠️ 920 (+25%)	1,003 (-9%)	388,047	7,723	10,144	250	512
public-kernel-setup	166 (+4%)	390 (-1%)	927 (-2%)	137,024	84,967	113,344	3,475	4,096
public-kernel-teardown	170 (+1%)	⚠️ 384 (-17%)	⚠️ 945 (-16%)	141,902	84,967	113,344	3,475	4,096
merge-rollup	6.79 (-1%)	⚠️ 89.2 (-43%)	⚠️ 1,570 (-33%)	2,696	925	3,104	30.0	65,536
private-kernel-tail-to-public	N/A	10,501 (-2%)	68,517 (+1%)	N/A	N/A	113,856	3,491	4,194,304

Stats on running time collected for app circuits

Function	app_circuit_proof_size_in_bytes	app_circuit_proving_time_in_ms	app_circuit_size_in_gates	app_circuit_num_public_inputs
SchnorrAccount:entrypoint	15,456	47,970	2,097,152	416
Test:emit_nullifier	15,456	2,599 (-1%)	65,536	416
FPC:fee_entrypoint_public	15,456	16,223	524,288	416
Token:transfer	15,456	39,567	2,097,152	416
FPC:fee_entrypoint_private	15,456	9,053 (+1%)	524,288	416
Token:unshield	15,456	37,055	2,097,152	416
SchnorrAccount:spend_private_authwit	15,456	2,656	131,072	416

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	13.2	21.6 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.772	0.665 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	62.4 (+1%)	97.8 (+1%)	315	621 (+2%)	1,191	2,368	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.640 (+1%)	0.605 (+1%)	0.573	0.580 (+2%)	0.565	0.565	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	74.1	143	452	908 (+2%)	1,771	3,530	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	106	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.647	0.645	0.616	0.624 (+2%)	0.615	0.615	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	81.2 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	108
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.713 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	84,584	673,157

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	37,532	3,708 (+2%)	113,753

Metric	0 public data writes	1 public data writes	2 public data writes	4 public data writes	8 public data writes
tx_sequencer_processing_time_ms	1,343 (+2%)	2,317 (+3%)	1,910 (+1%)	2,840 (+1%)	1,828 (+1%)