Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Keys): Populate recipient in outgoing #7177

Closed
Tracked by #5606
LHerskind opened this issue Jun 25, 2024 · 0 comments · Fixed by #7390
Closed
Tracked by #5606

feat(Keys): Populate recipient in outgoing #7177

LHerskind opened this issue Jun 25, 2024 · 0 comments · Fixed by #7390
Assignees
@sklppy88

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jun 25, 2024 •
edited
Loading

When sending an outgoing log, we are populating it with a recipient, however, these are currently just set to be 0.

In the payload.nr we for example have (twice)

// @todo This value needs to be populated!
let recipient = AztecAddress::from_field(0);

Instead we should be taking an input here. I think in most cases we can use the same address as the one we are using for incoming viewing as well. It might not necessarily be the case though, so it is not fully clear to me if we want to have it is as an extra argument or just populate it with the same value.
@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 25, 2024
This was referenced Jun 25, 2024
Closed
Merged
@sklppy88 sklppy88 self-assigned this Jul 7, 2024
This was referenced Jul 7, 2024
Closed
Merged
@sklppy88 sklppy88 moved this from Todo to In Review in A3 Jul 10, 2024
sklppy88 added a commit that referenced this issue Jul 16, 2024
@sklppy88
feat: populate recipient in outgoing (#7390)
3293244 
Resolves #7177.

With this, we are adding recipient to the outgoing log. I'm adding it as
another parameter to the emission, when we pass it in the normal
circumstance (without keys), it is using the same value as the incoming
viewer.
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jul 16, 2024
@nventuro nventuro mentioned this issue Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklppy88 sklppy88

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: populate recipient in outgoing AztecProtocol/aztec-packages
2 participants
@LHerskind @sklppy88