Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Event_Logs): Remove event selector from L2UnencryptedLog #7198

Closed
Tracked by #2783
sklppy88 opened this issue Jun 26, 2024 · 0 comments · Fixed by #7309
Closed
Tracked by #2783

fix(Event_Logs): Remove event selector from L2UnencryptedLog #7198

sklppy88 opened this issue Jun 26, 2024 · 0 comments · Fixed by #7309
Assignees
@sklppy88

Comments

@sklppy88
Copy link
Contributor 

          You can do it in a separate PR, but I guess if event selector is being dropped (ie not enshrined) then it would make sense to remove it from UnencryptedL2Log as well (which is I think what the kernel uses).

Originally posted by @fcarreiro in #7192 (comment)
@github-project-automation github-project-automation bot moved this to Todo in A3 Jun 26, 2024
@sklppy88 sklppy88 mentioned this issue Jun 26, 2024
Merged
@sklppy88 sklppy88 self-assigned this Jun 27, 2024
@sklppy88 sklppy88 mentioned this issue Jun 28, 2024
Open
@sklppy88 sklppy88 changed the title Remove event selector from L2UnencryptedLog fix(Event Logs): Remove event selector from L2UnencryptedLog Jun 28, 2024
@sklppy88 sklppy88 changed the title fix(Event Logs): Remove event selector from L2UnencryptedLog fix(Event_Logs): Remove event selector from L2UnencryptedLog Jun 28, 2024
@sklppy88 sklppy88 mentioned this issue Jun 28, 2024
Merged
LHerskind added a commit that referenced this issue Jun 28, 2024
@sklppy88 @LHerskind
feat: Unify unencrypted log emission and decoding (#7232)
354dba2 
Currently event_selectors for unencrypted_l2_logs emitted from public
default to 0.

This will be further investigated and addressed with #7198.

---------

Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com>
This was referenced Jun 28, 2024
Closed
Merged
@sklppy88 sklppy88 linked a pull request Jul 3, 2024 that will close this issue
fix: remove event selector from unencrypted log #7309
Merged
sklppy88 added a commit that referenced this issue Jul 4, 2024
@sklppy88
fix: remove event selector from unencrypted log (#7309)
c6eb734 
Addresses #7198 and #6578.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklppy88 sklppy88

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove event selector from unencrypted log AztecProtocol/aztec-packages
1 participant
@sklppy88