feat: typing unfinalized partial notes

[benesjan]

Fixes #7585

[benesjan]

• feat: typing unfinalized partial notes #7742 : 2 dependent PRs (#7765 , #7767 ) 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 3,515 (-24%)
• avm_simulation_time_ms (Token:transfer_public): 45.0 (+61%)
• l2_block_public_tx_process_time_in_ms (4): 9,087 (+16%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,729	1,541	705	743 (+1%)	768 (+1%)
proof_construction_time_sha256_30_ms	11,734	3,139	1,406 (-1%)	1,436	1,463 (-2%)
proof_construction_time_sha256_100_ms	43,854	12,513 (+1%)	5,653 (-1%)	5,571	5,505 (-1%)
proof_construction_time_poseidon_hash_ms	78.0	35.0 (+3%)	34.0	58.0 (-3%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,518	416	201 (+1%)	230 (+4%)	267
proof_construction_time_poseidon_hash_100_ms	5,618	1,515	680 (+1%)	726	751

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	740	740	740
l1_rollup_calldata_gas	6,716	6,708	6,704
l1_rollup_execution_gas	611,983	612,126	612,273
l2_block_processing_time_in_ms	259 (+5%)	448 (-3%)	929 (+13%)
l2_block_building_time_in_ms	10,765 (+15%)	18,370	38,235 (+4%)
l2_block_rollup_simulation_time_in_ms	10,765 (+15%)	18,369	38,235 (+4%)
l2_block_public_tx_process_time_in_ms	⚠️ 9,087 (+16%)	16,586	36,394 (+5%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,774 (-1%)	3,707 (-2%)
node_database_size_in_bytes	12,722,256	16,912,464
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	103 (+8%)	390	21,846	44,858	N/A	N/A	N/A	N/A
private-kernel-inner	171 (+2%)	686	72,545	45,005	N/A	N/A	N/A	N/A
private-kernel-tail	700 (+1%)	838 (+1%)	53,523	49,801	N/A	N/A	N/A	N/A
base-parity	5.96 (+3%)	594 (+1%)	160	96.0	1,878 (+9%)	13,188	19.0	65,536
root-parity	111 (+2%)	125 (-2%)	69,084	96.0	31,087 (+2%)	13,188	19.0	4,194,304
base-rollup	2,976 (+1%)	5,333 (+1%)	182,288	664	97,006 (+1%)	14,020	45.0	16,777,216
root-rollup	97.3	119 (+1%)	54,525	716	28,423 (-1%)	13,988	44.0	4,194,304
public-kernel-setup	88.0 (-3%)	2,802	102,617	69,814	17,657 (+1%)	127,172	3,581	2,097,152
public-kernel-app-logic	106 (+2%)	4,134 (+1%)	102,617	69,814	10,751 (+1%)	127,172	3,581	1,048,576
public-kernel-tail	579 (+1%)	30,172 (+8%)	402,342	10,878	106,420 (+2%)	26,436	433	16,777,216
private-kernel-reset-tiny	198 (-21%)	824	68,621	44,750	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	⚠️ 3,515 (-24%)	1,565 (+1%)	977,330	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	84.3 (-1%)	4,171 (+3%)	102,617	69,814	19,604 (+2%)	127,172	3,581	2,097,152
merge-rollup	60.8 (+1%)	N/A	35,742	664	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	154,685 (-1%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,344	11,731	340 (+2%)	N/A	N/A
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (+2%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	11,731	474 (+1%)	N/A	N/A
GasToken:deploy	1,376	11,731	376 (+1%)	N/A	N/A
SchnorrAccount:constructor	1,312	11,731	174	N/A	N/A
SchnorrAccount:entrypoint	2,304	11,731	573 (+3%)	N/A	N/A
Token:privately_mint_private_note	1,280	11,731	216	N/A	N/A
FPC:fee_entrypoint_public	1,344	11,731	33.1 (-7%)	N/A	N/A
Token:transfer	1,312	11,731	791 (+1%)	N/A	N/A
AuthRegistry:set_authorized (avm)	18,491	N/A	N/A	147,456	2,625 (+6%)
FPC:prepare_fee (avm)	22,958	N/A	N/A	147,520	3,294 (+6%)
Token:transfer_public (avm)	61,614	N/A	N/A	147,520	18,055 (+3%)
AuthRegistry:consume (avm)	41,719	N/A	N/A	147,488	7,582 (+3%)
FPC:pay_refund (avm)	26,227	N/A	N/A	147,488	7,360 (+1%)
Benchmarking:create_note	1,344	11,731	178 (+5%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	11,731	27.7 (+1%)	N/A	N/A
Token:unshield	1,376	11,731	753 (+2%)	N/A	N/A
FPC:fee_entrypoint_private	1,376	11,731	991 (+2%)	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	90.8 (+2%)	8,139
GasToken:set_portal	11.2 (+16%)	2,362
Token:constructor	118	31,107
FPC:constructor	91.4 (-1%)	24,011
GasToken:mint_public	75.6 (-1%)	6,150
Token:mint_public	80.8 (-3%)	11,720
Token:assert_minter_and_mint	86.6	8,028
AuthRegistry:set_authorized	9.33 (+5%)	4,537
FPC:prepare_fee	291 (-6%)	8,812
Token:transfer_public	⚠️ 45.0 (+61%)	47,374
FPC:pay_refund	62.3 (-11%)	12,114
Benchmarking:increment_balance	1,000 (+2%)	7,450
Token:_increase_public_balance	10.3 (+9%)	8,960
FPC:pay_refund_with_shielded_rebate	139	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.153 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.13	3.86 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.111	0.109 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	10.9 (+1%)	19.5 (+10%)	33.9 (+11%)	58.7 (-4%)	119 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.105 (+1%)	0.114 (+10%)	0.110 (+10%)	0.101 (-4%)	0.106
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.0 (+1%)	25.4 (-3%)	42.5 (-2%)	82.4 (-2%)	163 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.107 (+1%)	0.103 (-2%)	0.103 (-2%)	0.101 (-2%)	0.102 (-4%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.105	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	62,729	664,455

Transaction size based on fee payment method

| Metric | |
| - | |

[benesjan]

What does the reviewer think? Maybe NoteWithAmount?

[benesjan]

Moved this over from the original description in TokeNote since it no longer made sense to have it there.

[sklppy88]

Looks very nice 🙏