Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nuking unnecessary siloing #7774

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Aug 5, 2024

This shaves off only 1214 gates but it was easy to do so seems worth it to have it in.

Copy link
Contributor Author

benesjan commented Aug 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite Graphite

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Changes to circuit sizes

Generated at commit: 12f2d4534cf1eb2fe09981f1b7769b0720c23d78, compared to commit: 5db077cd80bdd07f4f33c4c9c7ff651c4fee248b

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base +260 ❌ +0.08% +4,674,625 ❌ +121.85%
public_kernel_tail +258 ❌ +0.03% +4,419,130 ❌ +91.14%
rollup_root +1 ❌ +0.02% +31,751 ❌ +1.01%
parity_root +1 ❌ +0.02% +1,700 ❌ +0.04%
private_kernel_inner +1 ❌ +0.00% -357 ✅ -0.53%
private_kernel_init +1 ❌ +0.00% -357 ✅ -0.91%
private_kernel_reset_tiny +1 ❌ +0.00% -17,009 ✅ -14.77%
private_kernel_reset_small +1 ❌ +0.00% -33,981 ✅ -21.49%
private_kernel_reset_medium +1 ❌ +0.00% -67,925 ✅ -27.82%
private_kernel_reset_big +1 ❌ +0.00% -135,813 ✅ -32.61%
private_kernel_reset +1 ❌ +0.00% -271,589 ✅ -35.69%
parity_base +2 ❌ +0.58% -28,854 ✅ -36.15%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base 341,730 (+260) +0.08% 8,511,019 (+4,674,625) +121.85%
public_kernel_tail 1,001,712 (+258) +0.03% 9,268,037 (+4,419,130) +91.14%
rollup_root 4,337 (+1) +0.02% 3,179,742 (+31,751) +1.01%
parity_root 5,030 (+1) +0.02% 4,179,166 (+1,700) +0.04%
private_kernel_inner 50,019 (+1) +0.00% 66,951 (-357) -0.53%
private_kernel_init 28,621 (+1) +0.00% 38,884 (-357) -0.91%
private_kernel_reset_tiny 57,746 (+1) +0.00% 98,186 (-17,009) -14.77%
private_kernel_reset_small 61,158 (+1) +0.00% 124,144 (-33,981) -21.49%
private_kernel_reset_medium 67,985 (+1) +0.00% 176,239 (-67,925) -27.82%
private_kernel_reset_big 81,638 (+1) +0.00% 280,636 (-135,813) -32.61%
private_kernel_reset 108,942 (+1) +0.00% 489,428 (-271,589) -35.69%
parity_base 349 (+2) +0.58% 50,957 (-28,854) -36.15%

@benesjan
Copy link
Contributor Author

benesjan commented Aug 6, 2024

Closing this as it makes 'using nsk_app to detect nullification' test case impossible

@benesjan benesjan closed this Aug 6, 2024
@benesjan benesjan deleted the 08-05-feat_nuking_unnecessary_siloing branch August 6, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant