Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch BalancesMap to use ValueNote instead of TokenNote #8107

Closed
nventuro opened this issue Aug 21, 2024 · 0 comments · Fixed by #8143
Closed

Switch BalancesMap to use ValueNote instead of TokenNote #8107

nventuro opened this issue Aug 21, 2024 · 0 comments · Fixed by #8143
Assignees
@sklppy88

Comments

@nventuro
Copy link
Contributor

There seems to be no good reason why TokenNote is used instead of the plain ValueNote (except that Value lacks the partial note API - to be fixed in #8105) - we should try to use ValueNote and delete TokenNote.
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 21, 2024
@sklppy88 sklppy88 self-assigned this Aug 21, 2024
@sklppy88 sklppy88 moved this from Todo to In Review in A3 Aug 27, 2024
This was referenced Aug 27, 2024
Merged
Merged
nventuro pushed a commit that referenced this issue Sep 6, 2024
@sklppy88
refactor: add uint (U128) note to aztec-nr and remove OwnedNote from …
225b6d3 
…ValueNote (#8142)

In this PR we are just adding a new note type to aztec-nr. This is
simply tokennote, but we are doing the addition of this note and the
removal of tokennote in two steps to make the diffs easier to
understand. This also removes `OwnedNote` from `ValueNote`.

Sets up resolving of #8107.
nventuro pushed a commit that referenced this issue Oct 27, 2024
@sklppy88
refactor: replace token note with uint note (#8143)
493a3f3 
In this PR, we are replacing the token note with our previously added
U128 note and making BalanceSet hold a UintNote instead of being
generic. The token note is now redundant as we have a UintNote in aztec
nr now.

Resolves #8107.
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Oct 27, 2024
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklppy88 sklppy88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace token note with uint note AztecProtocol/aztec-packages
2 participants
@nventuro @sklppy88