refactor: nuking log_traits.nr
#8797
Merged
+84
−492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
changed the title
log_traits.nr
benesjan
commented
Sep 25, 2024
| @@ -0,0 +1,25 @@ | |||
| pub fn arr_to_be_bytes_arr<let L: u32>(fields: [Field; L]) -> [u8; L * 32] { | |||
There was a problem hiding this comment.
Moved these functions from log_traits.nr + refactored them such that they work with arrays instead of slices (we no longer need slices here with arithmetic over generics).
benesjan
force-pushed
the
09-25-feat_encryption_cleanup
branch
from
12826ad
to
1cb97db
Compare
benesjan
force-pushed
the
09-25-refactor_nuking
branch
from
fb9379f
to
3be7371
Compare
benesjan
force-pushed
the
09-25-feat_encryption_cleanup
branch
from
1cb97db
to
8d1132a
Compare
benesjan
force-pushed
the
09-25-refactor_nuking
branch
from
3be7371
to
1cd0dec
Compare
benesjan
force-pushed
the
09-25-refactor_nuking
branch
from
1cd0dec
to
94d31f3
Compare
benesjan
force-pushed
the
09-25-refactor_nuking
branch
from
399ab22
to
6911fc2
Compare
sklppy88
approved these changes
Sep 26, 2024
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8548