refactor: cleanup of Aztec.nr encryption code
#8780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
commented
Sep 25, 2024
benesjan
commented
Sep 25, 2024
benesjan
commented
Sep 25, 2024
benesjan
commented
Sep 25, 2024
benesjan
commented
Sep 25, 2024
...es/src/logs/l1_payload/encrypted_log_incoming_body/encrypted_event_log_incoming_body.test.ts
Show resolved
Hide resolved
benesjan
changed the title
benesjan
changed the title
Aztec.nr encryption code
nventuro
approved these changes
Sep 25, 2024
| recipient, | ||
| event | ||
| ); | ||
| let plaintext = event.private_to_be_bytes(randomness); |
There was a problem hiding this comment.
Unrelated to this PR, but private_to_be_bytes needs a rename yesterday.
| recipient, | ||
| note | ||
| ); | ||
| let plaintext = note.to_be_bytes(storage_slot); |
There was a problem hiding this comment.
Actually, to_be_bytes in general needs a renaming. Thoroughly confused as to why this might receive a storage slot.
benesjan
force-pushed
the
janb/partial-notes-encoding-revert
branch
from
cabff17
to
013bc7a
Compare
benesjan
force-pushed
the
09-25-feat_encryption_cleanup
branch
from
12826ad
to
1cb97db
Compare
Base automatically changed from
janb/partial-notes-encoding-revert
to
master
September 26, 2024 06:58
benesjan
force-pushed
the
09-25-feat_encryption_cleanup
branch
from
1cb97db
to
8d1132a
Compare
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple issues with how encryption was done:
compute_encrypted_note_logandcompute_encrypted_event_logdoing essentially the same thing but we had it duplicate because instead of accepting plaintext it accepted specific abstract types which were not even needed for anything,EncryptedLogIncomingBodyandEncryptedLogOutgoingBodystructs but in all the cases we always just constructed them and then we immediately calledcompute_ciphertext(...)on the struct.I tackled issue 1. by merging the functions and just having a plaintext on the input and I tackled 2 by replacing the structs with
compute_incoming_body_ciphertextandcompute_outgoing_body_ciphertextfunctions.If the reviewers agree with changes in this PR I will proceed with doing the same in TS.