-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use different rust toolchain for foundry builds #8869
Conversation
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
function setUp() public {} | ||
function setUp() public { | ||
// Pause gas metering as calculating the root on each insert is expensive | ||
vm.pauseGasMetering(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, have not seen this before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing it 1000 times in a loop in this test, for each tree. Was making it exceed limits. I assumed its fine to just not meter as we dont use it like this in prod.
Overview
Cargo version installed by default in
build-images
was not the minimum required for the newer release of foundry that was pinned in #8868, this alters thefoundry-build
earthly script to use1.80
rustc version. This is set through adding a toolchain file so the correct binary will be installed automatically.In the future if we need to bump the version for builds, we can just alter this toolchain version.
This also runs forge fmt for this updated version