Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use different rust toolchain for foundry builds #8869

Merged
merged 7 commits into from
Sep 28, 2024

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Sep 28, 2024

Overview

Cargo version installed by default in build-images was not the minimum required for the newer release of foundry that was pinned in #8868, this alters the foundry-build earthly script to use 1.80 rustc version. This is set through adding a toolchain file so the correct binary will be installed automatically.

In the future if we need to bump the version for builds, we can just alter this toolchain version.

This also runs forge fmt for this updated version

Copy link
Contributor

github-actions bot commented Sep 28, 2024

Changes to public function bytecode sizes

Generated at commit: 4bdd37ce6effa0b529bbf6e2f11d05e5cc5f28d6, compared to commit: 4354ae030b5b7e365ff0361e88cd74cd95d71e04

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
CardGame::public_dispatch +540 ❌ +1.85%
Uniswap::public_dispatch +63 ❌ +0.19%
Token::public_dispatch +126 ❌ +0.17%
FPC::public_dispatch +14 ❌ +0.12%
AvmTest::public_dispatch +105 ❌ +0.11%
NFT::public_dispatch +14 ❌ +0.03%
StatefulTest::public_dispatch -7 ✅ -0.05%
TokenBridge::public_dispatch -21 ✅ -0.06%
InclusionProofs::public_dispatch -7 ✅ -0.12%
Lending::public_dispatch -1,552 ✅ -1.81%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
CardGame::public_dispatch 29,782 (+540) +1.85%
Uniswap::public_dispatch 33,755 (+63) +0.19%
Token::public_dispatch 72,494 (+126) +0.17%
FPC::public_dispatch 11,393 (+14) +0.12%
AvmTest::public_dispatch 97,383 (+105) +0.11%
NFT::public_dispatch 43,250 (+14) +0.03%
StatefulTest::public_dispatch 13,711 (-7) -0.05%
TokenBridge::public_dispatch 32,374 (-21) -0.06%
InclusionProofs::public_dispatch 5,819 (-7) -0.12%
Lending::public_dispatch 84,409 (-1,552) -1.81%

@Maddiaa0 Maddiaa0 added the e2e-all CI: Enables this CI job. label Sep 28, 2024
function setUp() public {}
function setUp() public {
// Pause gas metering as calculating the root on each insert is expensive
vm.pauseGasMetering();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, have not seen this before

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing it 1000 times in a loop in this test, for each tree. Was making it exceed limits. I assumed its fine to just not meter as we dont use it like this in prod.

@LHerskind LHerskind merged commit 096a0b2 into master Sep 28, 2024
94 of 129 checks passed
@LHerskind LHerskind deleted the md/fix-foundry-build branch September 28, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants