Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove handling of duplicates from the note hash tree #10016

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

PhilWindle
Copy link
Collaborator

This PR removes the abilitity to handle duplicates in the note hash tree. Since #9492, all trees now contain unique leaves only. Removing the handling of duplicates reduces the complexity and storage requirements of the trees.

@PhilWindle PhilWindle added the e2e-all CI: Enables this CI job. label Nov 17, 2024
@PhilWindle PhilWindle changed the base branch from master to pw/data-config November 17, 2024 18:45
Base automatically changed from pw/data-config to master November 19, 2024 12:04
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 4ca1f3d475be714f05103b06c3059d57547e7046, compared to commit: 9ad24dd7afd4cb83429562cac559ed71800d1aa7

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public -25,379 ✅ -5.37% +251,515 ❌ +6.71%
rollup_base_private -137,564 ✅ -41.03% -750,997 ✅ -22.03%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public 447,125 (-25,379) -5.37% 3,997,443 (+251,515) +6.71%
rollup_base_private 197,673 (-137,564) -41.03% 2,658,579 (-750,997) -22.03%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants