feat: calls to non-existent contracts in the AVM simulator return failure #10051
+96
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
commented
Nov 20, 2024
Comment on lines
+936
to
+950
| it(`Nested call to non-existent contract `, async () => { | ||
| const calldata = [value0, value1]; | ||
| const context = createContext(calldata); | ||
| const callBytecode = getAvmTestContractBytecode('nested_call_to_add'); | ||
|
|
||
| const nestedTrace = mock<PublicSideEffectTraceInterface>(); | ||
| mockTraceFork(trace, nestedTrace); | ||
|
|
||
| const results = await new AvmSimulator(context).executeBytecode(callBytecode); | ||
| expect(results.reverted).toBe(true); | ||
| expect(results.output).toEqual([]); | ||
|
|
||
| expectTracedNestedCall(context.environment, nestedTrace, /*isStaticCall=*/ false, /*exists=*/ false); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Testing non-existent contract by not mocking getBytecode
dbanks12
commented
Nov 20, 2024
Comment on lines
-86
to
104
| // This assumes that we will not be able to send messages to accounts without code | ||
| // Pending classes and instances impl details | ||
| if (!bytecode) { | ||
| throw new NoBytecodeForContractError(this.context.environment.address); | ||
| // revert without consuming any gas | ||
| const message = `No bytecode found at: ${this.context.environment.address}. Reverting...`; | ||
| const revertReason = new AvmRevertReason( | ||
| message, | ||
| /*failingFunction=*/ { | ||
| contractAddress: this.context.environment.address, | ||
| functionSelector: this.context.environment.functionSelector, | ||
| }, | ||
| /*noirCallStack=*/ [], | ||
| ); | ||
| this.log.warn(message); | ||
| return new AvmContractCallResult( | ||
| /*reverted=*/ true, | ||
| /*output=*/ [], | ||
| /*gasLeft=*/ this.context.machineState.gasLeft, | ||
| revertReason, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Is it bad to hand-craft an AvmRevertReason like this?
dbanks12
commented
Nov 20, 2024
Comment on lines
+90
to
+94
| // should only charge gas for the call instruction itself | ||
| // (all gas allocated to the nested call should be refunded) | ||
| const callGasCost = instruction.gasCost(argsSize); | ||
| expect(context.machineState.l2GasLeft).toEqual(initialL2Gas - callGasCost.l2Gas); | ||
| expect(context.machineState.daGasLeft).toEqual(initialDaGas - callGasCost.daGas); |
There was a problem hiding this comment.
changed instruction.gasCost from protected to public so that I can confirm here that the external call is charging no more than the cost of the call opcode itself. Is that an acceptable decision?
dbanks12
commented
Nov 20, 2024
Comment on lines
86
to
-89
| if (!bytecode) { | ||
| throw new NoBytecodeForContractError(this.context.environment.address); |
There was a problem hiding this comment.
If we "throw" then we'd need to wrap calls to the AVM in try-catch. It would be fine for external calls, but breaks things for enqueued calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call to a non-existent contract does nothing and returns failure. The nested context does not consume any gas. The
getBytecodeis still traced because the circuit will need a hint to know that it should do a non-membership check of the contract.If it is a nested call, the CALL opcode consumes its regular gas, but the nested context consumes nothing, so the entire gas allocation is refunded to the caller.