Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(circuits): cleanup in kernel circuits and tests #1091

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

dbanks12
Copy link
Contributor

@dbanks12 dbanks12 commented Jul 17, 2023

Description

  • Use builder assertions instead of ASSERT
  • Add a missing read request tests to initial kernel tests
    • They already exist for inner kernel tests here, so they are mostly copy-pasted

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would almost think the error messages are too verbose, but I know all too well how needed that stuff is now :D

@dbanks12 dbanks12 merged commit ddcaea9 into master Jul 17, 2023
@dbanks12 dbanks12 deleted the db/circuits-tests-cleanup branch July 17, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants