Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing prettier plugin for import ordering #1094

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

spalladino
Copy link
Collaborator

#1069 added enforcement for import orders, but it depends on a prettier plugin that was not included, so all formatting runs failed to format imports with the warnings:

[warn] Ignored unknown option { importOrder: ["^@aztec/(.*)$", "<THIRD_PARTY_MODULES>", "^\\./|\\.\\./"] }.
[warn] Ignored unknown option { importOrderSeparation: true }.
[warn] Ignored unknown option { importOrderSortSpecifiers: true }.

This PR adds the missing plugin as a dependency, re-formats all files, and adds a setting to handle the type: json type assertion in imports (which failed with an error otherwise).

@spalladino spalladino requested a review from spypsy July 17, 2023 19:23
@spalladino spalladino changed the title Add missing prettier plugin Add missing prettier plugin for import ordering Jul 17, 2023
@spypsy
Copy link
Member

spypsy commented Jul 17, 2023

ah, apologies I may have had it installed globally

@spalladino spalladino enabled auto-merge (squash) July 17, 2023 19:31
@spalladino spalladino merged commit 3e3362c into master Jul 17, 2023
@spalladino spalladino deleted the palla/fix-import-order branch July 17, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants