Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e test that sends notes from 1 rpc server to another #1103

Merged
merged 22 commits into from
Jul 20, 2023
Merged

e2e test that sends notes from 1 rpc server to another #1103

merged 22 commits into from
Jul 20, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jul 18, 2023 •
edited
Loading

Description

  1. Fixes Create an e2e test that sends notes from 1 rpc server to another #1067,
  2. suffixed loggers in RPC server with random string to be able to distinguish different instances,
  3. when attaching logs in L2Block error doesn't get thrown when a log is attached the second time but it's the same object (this started occurring because aztec node's blocks already had logs attached by synchroniser in RPC server 1 --> this should not occur when we have a real HTTP connection with aztec node and not just a simple interface),
  4. added the needed functions to RPC server and renamed some for the naming to be consistent).

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan changed the title refactor: split setup to 2 functions e2e test that sends notes from 1 rpc server to another Jul 18, 2023
@benesjan benesjan marked this pull request as draft July 18, 2023 14:08
@benesjan benesjan force-pushed the janb/e2e-2-rpc-servers branch 3 times, most recently from 4269ea8 to 94311b2 Compare July 19, 2023 11:48
@benesjan benesjan marked this pull request as ready for review July 19, 2023 12:07
@benesjan benesjan force-pushed the janb/e2e-2-rpc-servers branch 2 times, most recently from 56ea99e to eea24f7 Compare July 19, 2023 14:20
@benesjan benesjan requested a review from spalladino July 19, 2023 14:20
spalladino
spalladino approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nitpicks which can be totally ignored.

yarn-project/aztec-rpc/src/aztec_rpc_server/aztec_rpc_server.ts Outdated Show resolved Hide resolved
yarn-project/end-to-end/src/utils.ts Outdated Show resolved Hide resolved
yarn-project/end-to-end/src/e2e_2_rpc_servers.test.ts Outdated Show resolved Hide resolved
yarn-project/end-to-end/src/e2e_2_rpc_servers.test.ts Show resolved Hide resolved
@benesjan benesjan merged commit d53eadc into master Jul 20, 2023
@benesjan benesjan deleted the janb/e2e-2-rpc-servers branch July 20, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an e2e test that sends notes from 1 rpc server to another
2 participants
@benesjan @spalladino