chore(e2e): Test multiple decryption keys on the same tx #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
force-pushed
the
palla/e2e-multiple-keys
branch
from
0476276
to
0754be6
Compare
✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.
|
spalladino
force-pushed
the
palla/e2e-multiple-keys
branch
7 times, most recently
from
cd019e4
to
83394c2
Compare
spalladino
commented
Jul 31, 2023
Comment on lines
+87
to
+91
| it('refuses to withdraw funds as a non-owner', async () => { | ||
| await expect( | ||
| escrowContract.methods.withdraw(zkTokenContract.address, 30, recipient).simulate({ origin: recipient }), | ||
| ).rejects.toThrowError(); | ||
| }, 60_000); |
There was a problem hiding this comment.
I'd've expected this test to fail with a cannot satisfy constraints, but I got this error instead. For context, I'm running an ensure_note_exists for a note which does not exist. Is it possible to catch this somehow? cc @LeilaWang
wasm Error(2018): private data tree root mismatch at read_request[0]
wasm expected root: 0x01834dbe674ccaa98f5aaafdcd8a42267503a0c141f582ad7f53564fab450c23
wasm but got root*: 0x23b12bc80a094747ce77a30b71288abcb7cbf648a8891cfe907405db219c8549
wasm read_request: 0x156409eef4798a1db5b3a8d73dfa047c3c0de0f06fc888209b1a191c31b5dde8
wasm siloed-rr (leaf): 0x1115a070391204040030b3f5e4ab5d5e6fc5b3c82e16be7de43f2b089961e7c6
wasm leaf_index: 0x0000000000000000000000000000000000000000000000000000000000000040
wasm is_transient: 0
wasm hint_to_commitment: 0x0000000000000000000000000000000000000000000000000000000000000000
wasm * got root by siloing read_request (compressing with storage_contract_address to get leaf) and merkle-hashing to a root using membership witness (mem: 34.50MB) +30s
spalladino
force-pushed
the
palla/e2e-multiple-keys
branch
from
1b66c4e
to
10fa8d8
Compare
benesjan
approved these changes
Jul 31, 2023
| global ADDRESS_NOTE_LEN: Field = 2; | ||
|
|
||
| // Stores an address | ||
| struct AddressNote { |
There was a problem hiding this comment.
I've already created AddressNote in the Pokeable contract. The only difference there is that owner and address are the same thing (it was enough for the test case I used pokeable contract for).
Maybe it would be worth it to remove my implementation of AddressNote and move yours to noir-libs. This sounds like something which will be needed by a lot of contracts. But maybe it would be better to do that in separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1010