Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emitting owner address through a note #1132

Merged
merged 6 commits into from
Jul 21, 2023
Merged

Emitting owner address through a note #1132

merged 6 commits into from
Jul 21, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jul 21, 2023 •
edited
Loading

Description

  1. Fixes Emitting owner address through a note #1133,
  2. minor improvements (typos, naming...).

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan marked this pull request as draft July 21, 2023 10:19
@benesjan benesjan changed the title Emitting address through a note Emitting owner address through a note Jul 21, 2023
@benesjan benesjan marked this pull request as ready for review July 21, 2023 12:35
PhilWindle
PhilWindle approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@PhilWindle PhilWindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@benesjan benesjan merged commit 47fc6ea into master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emitting owner address through a note
2 participants
@benesjan @PhilWindle