940 - getNotes filter nullified notes #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.
|
jeanmon
force-pushed
the
jm/940-filter-nullified-notes
branch
2 times, most recently
from
570a240
to
cd761fe
Compare
benesjan
force-pushed
the
jm/940-filter-nullified-notes
branch
2 times, most recently
from
b190be2
to
17bd3e6
Compare
jeanmon
force-pushed
the
jm/940-filter-nullified-notes
branch
8 times, most recently
from
c5b19a7
to
635f2aa
Compare
jeanmon
force-pushed
the
jm/940-filter-nullified-notes
branch
from
635f2aa
to
1f34198
Compare
dbanks12
approved these changes
Jul 27, 2023
Comment on lines
+207
to
+233
| * Update the list of pending notes by chopping a note which is nullified. | ||
| * The identifier used to determine matching is the inner note hash value. | ||
| * However, we adopt a defensive approach and ensure that the contract address | ||
| * and storage slot do match. | ||
| * Note that this method might be called with an innerNoteHash referring to | ||
| * a note created in a previous transaction which will result in this array | ||
| * of pending notes left unchanged. | ||
| * @param innerNoteHash - The inner note hash value to which note will be chopped. | ||
| * @param contractAddress - The contract address | ||
| * @param storageSlot - The storage slot as a Field Fr element | ||
| */ | ||
| public nullifyPendingNotes(innerNoteHash: Fr, contractAddress: AztecAddress, storageSlot: Fr) { | ||
| // IMPORTANT: We do need an in-place array mutation of this.pendingNotes as this array is shared | ||
| // by reference among the nested calls. That is the main reason for 'splice' usage below. | ||
| this.pendingNotes.splice( | ||
| 0, | ||
| this.pendingNotes.length, | ||
| ...this.pendingNotes.filter( | ||
| n => | ||
| !( | ||
| n.innerNoteHash.equals(innerNoteHash) && | ||
| n.contractAddress.equals(contractAddress) && | ||
| n.storageSlot.equals(storageSlot) | ||
| ), | ||
| ), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Nice! As a followup task, we can probably replace the PrivateFunctionExecution's newNotes and then clean up this chunk of code in the kernel prover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #940
Checklist: