Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ACVM and recompile with latest Noir #1239

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Bump ACVM and recompile with latest Noir #1239

merged 3 commits into from
Jul 27, 2023

Conversation

spalladino
Copy link
Collaborator

See conversation here

@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited
Loading

✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.

Name Link
🔨 Latest commit 6d5ef4f
🔍 Latest deploy log https://app.netlify.com/sites/preeminent-bienenstitch-606ad0/deploys/64c26e649cf2c60008a86b10

ludamad
ludamad approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. So we have more of a formal dependency than I thought, but the issue is it's a bit inconsistent (e.g. cloning noir master in bb acir tests). I guess a good next step is to at least make the noir and ACVM version chosen for various CI stuffs to match up

@dbanks12 dbanks12 self-requested a review July 27, 2023 14:09
@ludamad ludamad merged commit 4eb99df into master Jul 27, 2023
@ludamad ludamad deleted the palla/bump-acvm branch July 27, 2023 14:09
dbanks12
dbanks12 reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 left review comments

@ludamad ludamad ludamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalladino @ludamad @dbanks12