feat: encoder runtime arguments check #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preeminent-bienenstitch-606ad0 canceled.
|
|
Hopefully your next commit avoids the spot instance issues |
benesjan
force-pushed
the
janb/encoder-inputs-check
branch
2 times, most recently
from
e87754c
to
bd63152
Compare
PhilWindle
requested changes
Jul 31, 2023
| this.flattened.push(arg); | ||
| } else { | ||
| throw new Error('Object cannot be serialized to a field and is not a field.'); |
There was a problem hiding this comment.
I think I would just print 'Argument cannot be serialised to a field'.
There was a problem hiding this comment.
Addressed in 25d1ad1
benesjan
force-pushed
the
janb/encoder-inputs-check
branch
from
bd63152
to
25d1ad1
Compare
PhilWindle
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1227
Checklist: