Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Push siloed nullifier to pendingNullifiers #1472

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

suyash67
Copy link
Contributor

@suyash67 suyash67 commented Aug 8, 2023

The pendingNullifiers is used to filter out notes that are already spent. But currently while filtering, we compare a siloed nullifier with an inner nullifier:

// Remove notes which were already nullified during this transaction.
const dbNotesFiltered = dbNotes.filter(n => !this.pendingNullifiers.has(n.siloedNullifier as Fr));

This PR fixes it by adding a siloed nullifier to pendingNullifiers.

Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suyash67 suyash67 marked this pull request as ready for review August 8, 2023 21:14
@suyash67 suyash67 merged commit 5607e14 into master Aug 8, 2023
1 check passed
@suyash67 suyash67 deleted the sb/fix-pending-nullifiers branch August 8, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants