feat(noir): better NoteGetterOptions. #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NADA: u8, | ||
| DESC: u2, | ||
| ASC: u2, | ||
| NADA: u2, |
There was a problem hiding this comment.
Are we sticking with 'nada'? haha
There was a problem hiding this comment.
I don't have strong opinion on this. Any suggestion?
| @@ -64,13 +66,20 @@ impl<Note, N> Set<Note, N> { | |||
| destroy_note(context, self.storage_slot, note, self.note_interface); | |||
| } | |||
|
|
|||
| fn get_notes<S, P>( | |||
| fn get_notes<FILTER_ARGS>( | |||
There was a problem hiding this comment.
We should probably add a comment to say where to read more info about FILTER_ARGS - perhaps a link to the NoteGetterOptions file and a link to the docs?
I'm just thinking, if someone reads this Set method without having seen examples, they'll not know how to construct this template argument without help.
yarn-project/noir-libs/noir-aztec/src/note/note_getter_options.nr
Outdated
Show resolved
Hide resolved
LeilaWang
changed the title
iAmMichaelConnor
approved these changes
Aug 22, 2023
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Account bug fix (#1490) * fix account bug - remove y coordinate for public key nullifier * fix account bug in all relevant places in barretenberg * fix note_algorithms test * account circuit doc update for nullifier Y coord removal (account bug) * Added account nullifier content in notes_and_nullifiers.md. Fixed up some formatting in account_circuit.md and possibly fixed a typo * fixed up formatting in account circuit and notes/nullifiers docs * updated Verification Key since circuits were updated * fix: Build verification keys * fix: update circuit constants * reverting the root rollup constants changes * fix: update vk_hash in UpgradeV2 + fmt * Bigfield formula fix for single division (#1610) * Added division formula bug test * Fixed the single div bug by adding an unreduced zero to the formula * Trigger rebuild * Updated root rollup size * Update rollup names and add tests to more jobs * Updated some hashes and 1 test * Updated hashes and gate counts * Updated rollup gates * Revert adding extra information to log * Remove the cosmetic change * Updated hashes * fix: generate vks * fix: update `PROD_VK_HASH` in UpgradeV2 * check signing key on curve, and rename grumpkin.one (#1781) * check signing key on curve, and rename grumpkin.one * Rm commented-out line * update gate count & vkhash of js circuit * update vkhashes of all rollup circuits * Add `on_curve` check in stdlib point. * Update circuit keys. * Change root verifier circuit vk hash. * fix: generate vk contracts + upgrade prod_key_hash Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com> Co-authored-by: LHerskind <lasse.herskind@gmail.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com> Co-authored-by: arijitdutta67 <arijit.dutta67@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Michael Connor <mike@aztecprotocol.com> Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
This reverts commit 37adf5c.
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
This reverts commit 558c0a7.
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
Revert "Revert "Verification Key changes (#1695)""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoteGetterOptions::new().select(1, val).sort(0, SortOrder.DESC).set_limit(2).set_offset(10).view_notesapi toSet.view_noteapi to singletons.Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.