chore: update bootstrap.sh in Barretenberg to check for clang 16 #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orloaft
changed the title
Orloaft
changed the title
Orloaft
changed the title
|
LGTM |
|
Actually could we move this into the cpp bootstrap? I think this bootstrap isn't called by the other ones |
ludamad
reviewed
Aug 22, 2023
| @@ -1,6 +1,25 @@ | |||
| #!/bin/bash | |||
| set -eu | |||
|
|
|||
| # Get the clang version string | |||
| clang_version_string=$(clang --version 2>/dev/null) | |||
There was a problem hiding this comment.
nitpick: technically, since this script has -e, we would never hit the
# Check if clang is installed
if [ $? -ne 0 ]; then
echo "Error: clang is not installed."
exit 1
fi
case
There was a problem hiding this comment.
I'll add the set -e after this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1542 clang 16 is needed so a proposed solution is to check version in bootstrap.sh