Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use the pre-processor code snippet import method #1719

Merged
merged 3 commits into from
Aug 22, 2023
Merged

docs: Use the pre-processor code snippet import method #1719

merged 3 commits into from
Aug 22, 2023

Conversation

PhilWindle
Copy link
Collaborator

This PR updates the aztec sandbox getting started page to import code snippets just using the source pre-processor and removes the GithubCode plugin from the page.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@PhilWindle PhilWindle changed the title Use the pre-processor code snippet import method docs: Use the pre-processor code snippet import method Aug 22, 2023
@PhilWindle PhilWindle changed the title docs: Use the pre-processor code snippet import method doc: Use the pre-processor code snippet import method Aug 22, 2023
@PhilWindle PhilWindle changed the title doc: Use the pre-processor code snippet import method docs: Use the pre-processor code snippet import method Aug 22, 2023
benesjan
benesjan reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilWindle PhilWindle merged commit 54f6410 into master Aug 22, 2023
2 checks passed
@PhilWindle PhilWindle deleted the pw/sandbox-docs-code-refs branch August 22, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesjan benesjan benesjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilWindle @benesjan