Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: work around intermittent wasm webkit issue #2140

Merged
merged 3 commits into from
Sep 8, 2023
Merged

fix: work around intermittent wasm webkit issue #2140

merged 3 commits into from
Sep 8, 2023

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Sep 8, 2023 •
edited
Loading

Works around #2104

@ludamad ludamad changed the title fix: work around intermittent acir issue fix: work around intermittent wasm webkit issue Sep 8, 2023
@ludamad ludamad enabled auto-merge (squash) September 8, 2023 16:29
spalladino
spalladino approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github should autodetect "works around" as well as "fixes", so it can tag an issue as "doesn't hurt now, but will return and bite you later" instead of "fixed".

@ludamad ludamad merged commit a9b0934 into master Sep 8, 2023
2 checks passed
@ludamad ludamad deleted the ad/fix/run_acir_intermittent-error branch September 8, 2023 17:44
This was referenced Sep 8, 2023
Merged
Merged
PhilWindle pushed a commit that referenced this pull request Sep 8, 2023
@github-actions
chore(master): Release 0.6.1 (#2146)
1c39463 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.6.1</summary>

##
[0.6.1](aztec-packages-v0.5.2...aztec-packages-v0.6.1)
(2023-09-08)


### Features

* Example card game
([#2135](#2135))
([9084b89](9084b89))


### Bug Fixes

* **tests:** Increase test timeout
([#2144](#2144))
([7da9615](7da9615))
* Work around intermittent wasm webkit issue
([#2140](#2140))
([a9b0934](a9b0934))


### Miscellaneous

* **build:** Updated release please config
([#2142](#2142))
([e119c4f](e119c4f))
* **build:** Updated version check
([#2145](#2145))
([4ed5f05](4ed5f05))
* **master:** Release 0.5.2
([#2141](#2141))
([451aad6](451aad6))
* Release 0.5.2
([f76b53c](f76b53c))
* Release 0.6.1
([1bd1a79](1bd1a79))
</details>

<details><summary>barretenberg.js: 0.6.1</summary>

##
[0.6.1](barretenberg.js-v0.5.2...barretenberg.js-v0.6.1)
(2023-09-08)


### Miscellaneous

* **master:** Release 0.5.2
([#2141](#2141))
([451aad6](451aad6))
* Release 0.5.2
([f76b53c](f76b53c))
* Release 0.6.1
([1bd1a79](1bd1a79))
</details>

<details><summary>barretenberg: 0.6.1</summary>

##
[0.6.1](barretenberg-v0.5.2...barretenberg-v0.6.1)
(2023-09-08)


### Bug Fixes

* Work around intermittent wasm webkit issue
([#2140](#2140))
([a9b0934](a9b0934))


### Miscellaneous

* **master:** Release 0.5.2
([#2141](#2141))
([451aad6](451aad6))
* Release 0.5.2
([f76b53c](f76b53c))
* Release 0.6.1
([1bd1a79](1bd1a79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this pull request Sep 8, 2023
@github-actions @AztecBot
chore(master): Release 0.6.1 (#2146)
0418644 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.6.1</summary>

##
[0.6.1](AztecProtocol/aztec-packages@aztec-packages-v0.5.2...aztec-packages-v0.6.1)
(2023-09-08)


### Features

* Example card game
([#2135](AztecProtocol/aztec-packages#2135))
([9084b89](AztecProtocol/aztec-packages@9084b89))


### Bug Fixes

* **tests:** Increase test timeout
([#2144](AztecProtocol/aztec-packages#2144))
([7da9615](AztecProtocol/aztec-packages@7da9615))
* Work around intermittent wasm webkit issue
([#2140](AztecProtocol/aztec-packages#2140))
([a9b0934](AztecProtocol/aztec-packages@a9b0934))


### Miscellaneous

* **build:** Updated release please config
([#2142](AztecProtocol/aztec-packages#2142))
([e119c4f](AztecProtocol/aztec-packages@e119c4f))
* **build:** Updated version check
([#2145](AztecProtocol/aztec-packages#2145))
([4ed5f05](AztecProtocol/aztec-packages@4ed5f05))
* **master:** Release 0.5.2
([#2141](AztecProtocol/aztec-packages#2141))
([451aad6](AztecProtocol/aztec-packages@451aad6))
* Release 0.5.2
([f76b53c](AztecProtocol/aztec-packages@f76b53c))
* Release 0.6.1
([1bd1a79](AztecProtocol/aztec-packages@1bd1a79))
</details>

<details><summary>barretenberg.js: 0.6.1</summary>

##
[0.6.1](AztecProtocol/aztec-packages@barretenberg.js-v0.5.2...barretenberg.js-v0.6.1)
(2023-09-08)


### Miscellaneous

* **master:** Release 0.5.2
([#2141](AztecProtocol/aztec-packages#2141))
([451aad6](AztecProtocol/aztec-packages@451aad6))
* Release 0.5.2
([f76b53c](AztecProtocol/aztec-packages@f76b53c))
* Release 0.6.1
([1bd1a79](AztecProtocol/aztec-packages@1bd1a79))
</details>

<details><summary>barretenberg: 0.6.1</summary>

##
[0.6.1](AztecProtocol/aztec-packages@barretenberg-v0.5.2...barretenberg-v0.6.1)
(2023-09-08)


### Bug Fixes

* Work around intermittent wasm webkit issue
([#2140](AztecProtocol/aztec-packages#2140))
([a9b0934](AztecProtocol/aztec-packages@a9b0934))


### Miscellaneous

* **master:** Release 0.5.2
([#2141](AztecProtocol/aztec-packages#2141))
([451aad6](AztecProtocol/aztec-packages@451aad6))
* Release 0.5.2
([f76b53c](AztecProtocol/aztec-packages@f76b53c))
* Release 0.6.1
([1bd1a79](AztecProtocol/aztec-packages@1bd1a79))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludamad @spalladino