Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(1090): validate that some arrays are zero-padded on the right #2519

Merged
merged 8 commits into from
Sep 29, 2023
Merged

feat(1090): validate that some arrays are zero-padded on the right #2519

merged 8 commits into from
Sep 29, 2023

Commits on Sep 29, 2023

  1. 1090 - new routine to validate arrays and unit tests

    @jeanmon
    jeanmon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    6f9efe7 View commit details
    Browse the repository at this point in the history

  2. 1090 - activate the array validation in init and inner private kernel 

    circuit
    @jeanmon
    jeanmon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a64a292 View commit details
    Browse the repository at this point in the history

  3. 1090 - comments

    @jeanmon
    jeanmon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    659eeca View commit details
    Browse the repository at this point in the history

  4. 1090 - noir code should never push a zero nullified_commitment

    @jeanmon
    jeanmon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    fbb6ab9 View commit details
    Browse the repository at this point in the history

  5. 1090 - replaces a zero nullified_commitment by EMPTY placeholder 

            while pushing a new nullifier
    @jeanmon
    jeanmon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    333809d View commit details
    Browse the repository at this point in the history

  6. 1090 - add unit tests for private kernel circuit on malformed array 

    validation
    @jeanmon
    jeanmon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2405093 View commit details
    Browse the repository at this point in the history

  7. 1090 - rewording comments in unit tests

    @jeanmon
    jeanmon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    4a2726e View commit details
    Browse the repository at this point in the history

  8. 1090 - address review's feedback

    @jeanmon
    jeanmon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    19ed622 View commit details
    Browse the repository at this point in the history