New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add return type parsing for noir private kernel circuit #2762

Merged

kevaundray merged 2 commits into feature_branch/private-kernel from arv/return_type

Oct 10, 2023

Contributor

sirasistant commented Oct 10, 2023

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).


          feat: add parsing for the return value

c6d26d2

sirasistant requested a review from kevaundray

October 10, 2023 14:38

sirasistant changed the base branch from master to feature_branch/private-kernel

October 10, 2023 14:38


          test: added round trip tests

kevaundray merged commit c6c8e4b into feature_branch/private-kernel

80 checks passed

kevaundray deleted the arv/return_type branch

October 10, 2023 16:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet