-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use Noir javascript packages to execute the private kernel circuit init using the typescript generated types #2763
chore: Use Noir javascript packages to execute the private kernel circuit init using the typescript generated types #2763
Conversation
…script generated return type
…ript doesn't like this as is
A few changes were made here:
|
…nto kw/abi-types-encoding
// This is not great as we are exporting from tests. | ||
// Its okay for now and before merging into master, we should | ||
// remove this line. | ||
export {makePrivateKernelInputsInit} from '../tests/factories.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay tech debt at the moment -- until we want to merge into master, without it we will need to manually make an instance of PrivateKernelInputsInit in noir-private-kernel in order to have tests
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.