Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stale comments #2788

Merged
merged 1 commit into from
Oct 11, 2023
Merged

chore: remove stale comments #2788

merged 1 commit into from
Oct 11, 2023

Conversation

LHerskind
Copy link
Contributor

Removes stale comments related to #1473 and #1567

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@LHerskind LHerskind enabled auto-merge (squash) October 11, 2023 11:24
@LHerskind LHerskind merged commit d9c458d into master Oct 11, 2023
77 of 80 checks passed
@LHerskind LHerskind deleted the lh/stale-comments branch October 11, 2023 11:28
@AztecBot
Copy link
Collaborator

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45444 179588 716132
l1_rollup_calldata_gas 222744 867896 3448112
l1_rollup_execution_gas 841831 3595004 22203481
l2_block_processing_time_in_ms 1022 3849 15247
note_successful_decrypting_time_in_ms 319 976 3779
note_trial_decrypting_time_in_ms 23 84 139
l2_block_building_time_in_ms 8878 35598 148796
l2_block_rollup_simulation_time_in_ms 6600 26506 105062
l2_block_public_tx_process_time_in_ms 2237 8964 43269

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 10 blocks 20 blocks 30 blocks
node_history_sync_time_in_ms 32296 79127 140005
note_history_successful_decrypting_time_in_ms 4874 13726 20885
note_history_trial_decrypting_time_in_ms 149 271 307
node_database_size_in_bytes 1192450 1899981 2752819
pxe_database_size_in_bytes 54187 108338 162578

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 56.956288343558285 56577 14745
private-kernel-ordering 30.198619631901842 20137 8089
base-rollup 872 631604 810
root-rollup 38.21951219512195 4072 1097
private-kernel-inner 52.513888888888886 72288 14745
public-kernel-private-input 52.15972222222222 37359 14745
public-kernel-non-first-iteration 31.933641975308642 37401 14745
merge-rollup 1.050387596899225 2592 873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants