Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pedersen for addr nullifier #3027

Merged

Conversation

sirasistant
Copy link
Collaborator

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@sirasistant sirasistant marked this pull request as ready for review October 25, 2023 12:01
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • circuit_simulation_time_in_ms (private-kernel-init): 628 (+662%)
  • circuit_simulation_time_in_ms (private-kernel-ordering): 107 (+112%)
  • circuit_simulation_time_in_ms (private-kernel-inner): 593 (+913%)
  • note_history_successful_decrypting_time_in_ms (5): 1,891 (-26%)
  • note_history_successful_decrypting_time_in_ms (10): 3,685 (-26%)
  • note_successful_decrypting_time_in_ms (32): 834 (-20%)
  • note_successful_decrypting_time_in_ms (128): 3,048 (-21%)
  • note_trial_decrypting_time_in_ms (8): 95.0 (+116%)
  • note_trial_decrypting_time_in_ms (32): 43.0 (-63%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 388a47ba and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,924 868,328 3,449,576
l1_rollup_execution_gas 842,011 3,595,436 22,204,945
l2_block_processing_time_in_ms 2,302 (+2%) 8,791 (+1%) 34,392 (+1%)
note_successful_decrypting_time_in_ms 293 (-14%) ⚠️ 834 (-20%) ⚠️ 3,048 (-21%)
note_trial_decrypting_time_in_ms ⚠️ 95.0 (+116%) ⚠️ 43.0 (-63%) 137 (+1%)
l2_block_building_time_in_ms 14,501 (-1%) 58,018 232,231
l2_block_rollup_simulation_time_in_ms 13,176 52,729 211,001 (+1%)
l2_block_public_tx_process_time_in_ms 1,287 (-4%) 5,147 (-3%) 20,755 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 24,759 (-1%) 48,111 (-1%)
note_history_successful_decrypting_time_in_ms ⚠️ 1,891 (-26%) ⚠️ 3,685 (-26%)
note_history_trial_decrypting_time_in_ms 122 (+1%) 183 (+26%)
node_database_size_in_bytes 1,629,189 1,095,360
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init ⚠️ 628 (+662%) 61,697 18,905
private-kernel-ordering ⚠️ 107 (+112%) 24,297 8,153 (+1%)
base-rollup 2,087 656,311 814
root-rollup 89.6 4,072 1,097
private-kernel-inner ⚠️ 593 (+913%) 81,568 18,905
public-kernel-private-input 46.8 (+1%) 41,519 18,841
public-kernel-non-first-iteration 28.8 41,497 18,841
merge-rollup 0.870 (+6%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,787 (+1%) 27,304 (-7%)

@sirasistant sirasistant merged commit 28ec608 into feature_branch/private-kernel Oct 25, 2023
2 checks passed
@sirasistant sirasistant deleted the arv/dropped_tx_investigation branch October 25, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants