Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: historic access data tree #3159

Closed
wants to merge 13 commits into from
Closed

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Oct 31, 2023

Fixes #2584 as part of #2572

Adds getMembershipWitness oracle which currently provides both index and path. It only works for the data tree atm, but as part of #2572 should be made to work with the other trees.
Uses an AlmostValueNote as input since the macro is using the serialize function, which for ValueNote don't include the header so it is invalid.

Note: Based on #2585

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan changed the title Janb/historic storage access feat: historic access data tree Oct 31, 2023
@benesjan benesjan mentioned this pull request Oct 31, 2023
4 tasks
@benesjan benesjan marked this pull request as draft October 31, 2023 16:04
@benesjan
Copy link
Contributor Author

Replaced by #3255

@benesjan benesjan closed this Nov 20, 2023
@benesjan benesjan deleted the janb/historic_storage_access branch January 2, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Prove inclusion in historic data root
2 participants