Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove noirup from noir-contract's bootstrap #3252

Merged
merged 2 commits into from
Nov 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions yarn-project/noir-contracts/bootstrap.sh
Original file line number Diff line number Diff line change
@@ -1,15 +1,3 @@
#!/bin/bash
#!/usr/bin/env bash

# Install noir if it is not installed already
if ! command -v noirup &> /dev/null
then
echo "Installing noir"
source ./scripts/install_noirup.sh
fi

# Update noir
./scripts/install_noir.sh

# Use yarn script to compile and create types
yarn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this because the workspace will have installed dependencies before calling bootstrap in here.

yarn noir:build:all
yarn noir:build:all
2 changes: 1 addition & 1 deletion yarn-project/noir-contracts/scripts/compile.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ build() {
echo "Compiling $CONTRACT_NAME..."
rm -rf ${CONTRACT_FOLDER}/target

node "$COMPILER" contract "$CONTRACT_FOLDER"
node --no-warnings "$COMPILER" contract "$CONTRACT_FOLDER"
}

export -f build
Expand Down