Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pxe / node /p2p-bootstrap docker images #3396

Merged
merged 4 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 12 additions & 93 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -424,28 +424,6 @@ jobs:
echo "export DOCKER_BUILDKIT=" > $BASH_ENV
build cli false arm64

aztec-p2p-bootstrap:
machine:
image: ubuntu-2204:2023.07.2
resource_class: large
steps:
- *checkout
- *setup_env
- run:
name: "Build and test"
command: build p2p-bootstrap | add_timestamps

aztec-node:
machine:
image: ubuntu-2204:2023.07.2
resource_class: large
steps:
- *checkout
- *setup_env
- run:
name: "Build and test"
command: build aztec-node | add_timestamps

mainnet-fork:
machine:
image: ubuntu-2204:2023.07.2
Expand Down Expand Up @@ -479,32 +457,6 @@ jobs:
name: "Build and test"
command: build aztec-faucet | add_timestamps

pxe-x86_64:
machine:
image: ubuntu-2204:2023.07.2
resource_class: large
steps:
- *checkout
- *setup_env
- run:
name: "Build and test"
command: build pxe false x86_64

pxe-arm64:
machine:
image: ubuntu-2204:2023.07.2
resource_class: arm.large
steps:
- *checkout
- *setup_env
- run:
name: "Build and test"
# We need to force not to use docker buildkit because for some reason on arm only, it ends up making a call
# out to eu-west2 despite the image being locally tagged, resulting in unauthorized 401. Weird docker bug?
command: |
echo "export DOCKER_BUILDKIT=" > $BASH_ENV
build pxe false arm64

ecr-manifest:
machine:
image: ubuntu-2204:2023.07.2
Expand All @@ -516,7 +468,6 @@ jobs:
name: "Create ECR manifest"
command: |
create_ecr_manifest aztec-sandbox x86_64,arm64
create_ecr_manifest pxe x86_64,arm64
create_ecr_manifest cli x86_64,arm64

boxes-blank-react:
Expand Down Expand Up @@ -1033,17 +984,6 @@ jobs:
# name: "Deploy to dockerhub"
# command: yarn-project/deploy_dockerhub.sh canary

# deploy-ecr:
# machine:
# image: ubuntu-2204:2023.07.2
# resource_class: medium
# steps:
# - *checkout
# - *setup_env
# - run:
# name: "yarn-project"
# command: yarn-project/deploy_ecr.sh

deploy-dockerhub:
machine:
image: ubuntu-2204:2023.07.2
Expand Down Expand Up @@ -1112,7 +1052,7 @@ defaults: &defaults
- slack/notify:
event: fail
branch_pattern: "master"
deploy_defaults: &deploy_defaults
release_defaults: &release_defaults
filters:
tags:
only: *tag_regex
Expand Down Expand Up @@ -1201,7 +1141,7 @@ workflows:
- deploy-mainnet-fork:
requires:
- mainnet-fork
<<: *deploy_defaults
<<: *release_defaults

# Yarn Project
- yarn-project-base:
Expand Down Expand Up @@ -1254,36 +1194,15 @@ workflows:
- yarn-project
<<: *defaults

- aztec-p2p-bootstrap:
requires:
- yarn-project
<<: *defaults

- aztec-node:
requires:
- yarn-project
<<: *defaults

- aztec-faucet:
requires:
- yarn-project
<<: *defaults

- pxe-x86_64:
requires:
- yarn-project
<<: *defaults
- pxe-arm64:
requires:
- yarn-project
<<: *defaults

- ecr-manifest:
requires:
- aztec-sandbox-x86_64
- aztec-sandbox-arm64
- pxe-x86_64
- pxe-arm64
- cli-x86_64
- cli-arm64
<<: *defaults
Expand Down Expand Up @@ -1390,53 +1309,53 @@ workflows:
# - deploy-npm-canary:
# requires:
# - e2e-end
# <<: *deploy_defaults
# <<: *release_defaults
# - deploy-dockerhub-canary:
# requires:
# - e2e-end
# <<: *deploy_defaults
# <<: *release_defaults
# - deploy-ecr:
# requires:
# - e2e-end
# <<: *deploy_defaults
# <<: *release_defaults

# - build-deployment-canary:
# requires:
# - deploy-npm-canary
# - deploy-dockerhub-canary
# <<: *deploy_defaults
# <<: *release_defaults

# Run canary tests
# - canary-uniswap-test:
# requires:
# - build-deployment-canary
# <<: *deploy_defaults
# <<: *release_defaults

# - canary-browser-test:
# requires:
# - build-deployment-canary
# <<: *deploy_defaults
# <<: *release_defaults

# - canary-cli-test:
# requires:
# - build-deployment-canary
# <<: *deploy_defaults
# <<: *release_defaults

# - canary-end:
# requires:
# - canary-uniswap-test
# - canary-browser-test
# - canary-cli-test
# <<: *deploy_defaults
# <<: *release_defaults

# Production deployment
- deploy-dockerhub:
requires:
# - canary-end
- e2e-end
<<: *deploy_defaults
<<: *release_defaults
- deploy-npm:
requires:
# - canary-end
- e2e-end
<<: *deploy_defaults
<<: *release_defaults
12 changes: 4 additions & 8 deletions build-system/scripts/create_dockerhub_manifest
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,11 @@ DIST_TAG=${3:-"latest"}
echo "Repo: $REPOSITORY"
echo "Arch list: $ARCH_LIST"

ACCOUNT="aztecprotocol"
USERNAME="aztecprotocolci"

# Extract the version, if valid; exit otherwise.
IMAGE_TAG=$(extract_tag_version $REPOSITORY true)

MANIFEST_DEPLOY_URI=$ACCOUNT/$REPOSITORY:$IMAGE_TAG
MANIFEST_DIST_URI=$ACCOUNT/$REPOSITORY:$DIST_TAG
MANIFEST_DEPLOY_URI=$DOCKERHUB_ACCOUNT/$REPOSITORY:$IMAGE_TAG
MANIFEST_DIST_URI=$DOCKERHUB_ACCOUNT/$REPOSITORY:$DIST_TAG

# Login to dockerhub.
dockerhub_login
Expand All @@ -38,9 +35,8 @@ OLD_IFS=$IFS
IFS=','

# For each arch, add the tagged image to 2 manifest lists. One tagged with the version, the other with 'latest'
for A in $ARCH_LIST
do
IMAGE_DEPLOY_URI=$ACCOUNT/$REPOSITORY:$IMAGE_TAG-$A
for A in $ARCH_LIST; do
IMAGE_DEPLOY_URI=$DOCKERHUB_ACCOUNT/$REPOSITORY:$IMAGE_TAG-$A
echo "Adding image $IMAGE_DEPLOY_URI to manifest list $MANIFEST_DEPLOY_URI"
docker_or_dryrun manifest create $MANIFEST_DEPLOY_URI \
--amend $IMAGE_DEPLOY_URI
Expand Down
3 changes: 0 additions & 3 deletions build-system/scripts/deploy_dockerhub
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ DIST_TAG=${3:-"latest"}
echo "Repo: $REPOSITORY"
echo "Arch: $ARCH"

ACCOUNT="aztecprotocol"
USERNAME="aztecprotocolci"

IMAGE_COMMIT_URI=$(calculate_image_uri $REPOSITORY)

IMAGE_DIST_URI=$ACCOUNT/$REPOSITORY:$DIST_TAG
Expand Down
7 changes: 0 additions & 7 deletions build-system/scripts/docker_login

This file was deleted.

2 changes: 1 addition & 1 deletion build-system/scripts/dockerhub_login
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -eu
# Retries up to 3 times with 10 second intervals
for i in $(seq 1 3); do
echo "$DOCKERHUB_PASSWORD" | docker login -u aztecprotocolci --password-stdin && exit || sleep 10
echo "$DOCKERHUB_PASSWORD" | docker login -u $DOCKERHUB_USERNAME --password-stdin && exit || sleep 10
done
echo "$@ failed dockerhub_login after 3 attempts"
exit 1
2 changes: 2 additions & 0 deletions build-system/scripts/setup_env
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ echo export AWS_ACCOUNT=278380418400 >> $BASH_ENV
echo export ECR_URL=278380418400.dkr.ecr.us-east-2.amazonaws.com >> $BASH_ENV
echo export ECR_DEPLOY_REGION=eu-west-2 >> $BASH_ENV
echo export ECR_DEPLOY_URL=278380418400.dkr.ecr.eu-west-2.amazonaws.com >> $BASH_ENV
echo export DOCKERHUB_ACCOUNT=aztecprotocol >> $BASH_ENV
echo export DOCKERHUB_USERNAME=aztecprotocolci >> $BASH_ENV
echo export PROJECT=$PROJECT >> $BASH_ENV
echo export COMMIT_HASH=$COMMIT_HASH >> $BASH_ENV
echo export COMMIT_TAG=$COMMIT_TAG >> $BASH_ENV
Expand Down
18 changes: 0 additions & 18 deletions build_manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,6 @@ cli:
dependencies:
- yarn-project

pxe:
buildDir: yarn-project
projectDir: yarn-project/pxe
dependencies:
- yarn-project

boxes-blank-react:
buildDir: yarn-project
projectDir: yarn-project/boxes/blank-react
Expand Down Expand Up @@ -151,18 +145,6 @@ end-to-end:
runDependencies:
- aztec-sandbox

aztec-node:
buildDir: yarn-project
projectDir: yarn-project/aztec-node
dependencies:
- yarn-project

p2p-bootstrap:
buildDir: yarn-project
projectDir: yarn-project/p2p-bootstrap
dependencies:
- yarn-project

mainnet-fork:
buildDir: iac/mainnet-fork
projectDir: iac/mainnet-fork
Expand Down
4 changes: 0 additions & 4 deletions yarn-project/aztec-node/.dockerignore

This file was deleted.

14 changes: 0 additions & 14 deletions yarn-project/aztec-node/Dockerfile

This file was deleted.

2 changes: 1 addition & 1 deletion yarn-project/deploy_dockerhub.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ DIST_TAG=${1:-"latest"}
extract_repo yarn-project /usr/src project
PROJECT_ROOT=$(pwd)/project/src/

for REPOSITORY in "pxe" "aztec-sandbox" "cli"; do
for REPOSITORY in "aztec-sandbox" "cli"; do
echo "Deploying $REPOSITORY $DIST_TAG"
RELATIVE_PROJECT_DIR=$(query_manifest relativeProjectDir $REPOSITORY)
cd "$PROJECT_ROOT/$RELATIVE_PROJECT_DIR"
Expand Down
13 changes: 0 additions & 13 deletions yarn-project/deploy_ecr.sh

This file was deleted.

3 changes: 2 additions & 1 deletion yarn-project/end-to-end/scripts/docker-compose-p2p.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ services:
- '8545:8545'

p2p-bootstrap:
image: aztecprotocol/p2p-bootstrap:latest
image: aztecprotocol/aztec-sandbox:latest
ports:
- '40400:40400'
command: 'start'
environment:
MODE: 'p2p-bootstrap'
DEBUG: 'aztec:*'
DEBUG_COLORS: 1
P2P_TCP_LISTEN_PORT: 40400
Expand Down
14 changes: 0 additions & 14 deletions yarn-project/p2p-bootstrap/Dockerfile

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
version: '3'
services:
p2p-bootstrap:
image: 278380418400.dkr.ecr.eu-west-2.amazonaws.com/p2p-bootstrap:latest
image: 278380418400.dkr.ecr.eu-west-2.amazonaws.com/aztec-sandbox:latest
ports:
- '40400:40400'
environment:
MODE: 'p2p-bootstrap'
DEBUG: 'aztec:*'
P2P_TCP_LISTEN_PORT: 40400
PEER_ID: '0a260024080112205ea53185db2e52dae74d0d4d6cadc494174810d0a713cd09b0ac517c38bc781e1224080112205ea53185db2e52dae74d0d4d6cadc494174810d0a713cd09b0ac517c38bc781e1a44080112402df8b977f356c6e34fa021c9647973234dff4df706c185794405aafb556723cf5ea53185db2e52dae74d0d4d6cadc494174810d0a713cd09b0ac517c38bc781e'
Loading