Plumbs noir (for review only) NO MERGE #3427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
reviewed
Nov 27, 2023
| nvm install | ||
| set -eu | ||
|
|
||
| # if [ "$(uname)" = "Darwin" ]; then |
There was a problem hiding this comment.
removed commented in "full" pr.
Depending on nvm is nasty. It's now assumed the user has node 18 installed and available.
I believe we get appropriate version warnings if they dont.
ludamad
reviewed
Nov 27, 2023
| @@ -247,7 +247,7 @@ async function executePrivateKernelInitWithACVM(input: InitInputType): Promise<R | |||
| ); | |||
|
|
|||
| // Decode the witness map into two fields, the return values and the inputs | |||
| const decodedInputs: DecodedInputs = abiDecode(PrivateKernelInitSimulatedJson.abi, _witnessMap); | |||
| const decodedInputs: DecodedInputs = abiDecode(PrivateKernelInitSimulatedJson.abi as Abi, _witnessMap); | |||
|
|
|||
| // Cast the inputs as the return type | |||
| return decodedInputs.return_value as ReturnType; | |||
There was a problem hiding this comment.
not getting why this one has typecasts?
There was a problem hiding this comment.
I don't know why it wasn't an issue before.
This is the fact that JSON doesnt have type info so string != 'blah'
ludamad
approved these changes
Nov 27, 2023
charlielye
added a commit
that referenced
this pull request
Nov 27, 2023
For a less noisey review: #3427 It contains everything prior to the noir pulls. This is PR we actually want to merge though. * Adds `noir-packages` job to build the ts packages. * Fix `sed` use in bb.js to work on Mac. * Bootstrap scripts for noir, call it from bootstrap.sh. * Fix to `build_local`. * Use the noir bootstrap scripts to build the docker containers. * `yarn-project` now builds the protocol circuits from the noir build in bootstrap and dockerfile. * `yarn-project` portals the noir packages in. **What does this mean for releases!?* * Fixes as we're now on noir 19. * Remove `noir-protocol-circuits/src/target` from repo as they're now built. * Bootstrap improvements: * Defaults to a "lighter" bootstrap. * `bootstrap.sh clean` resets repo to as if fresh clone. (be careful). * Introduces ability to test the bootstrap process via a docker container. (might add a nightly job, plus alternative ubuntu releases).
AztecBot
pushed a commit
to AztecProtocol/build-system
that referenced
this pull request
Nov 28, 2023
For a less noisey review: AztecProtocol/aztec-packages#3427 It contains everything prior to the noir pulls. This is PR we actually want to merge though. * Adds `noir-packages` job to build the ts packages. * Fix `sed` use in bb.js to work on Mac. * Bootstrap scripts for noir, call it from bootstrap.sh. * Fix to `build_local`. * Use the noir bootstrap scripts to build the docker containers. * `yarn-project` now builds the protocol circuits from the noir build in bootstrap and dockerfile. * `yarn-project` portals the noir packages in. **What does this mean for releases!?* * Fixes as we're now on noir 19. * Remove `noir-protocol-circuits/src/target` from repo as they're now built. * Bootstrap improvements: * Defaults to a "lighter" bootstrap. * `bootstrap.sh clean` resets repo to as if fresh clone. (be careful). * Introduces ability to test the bootstrap process via a docker container. (might add a nightly job, plus alternative ubuntu releases).
AztecBot
pushed a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Nov 28, 2023
For a less noisey review: AztecProtocol/aztec-packages#3427 It contains everything prior to the noir pulls. This is PR we actually want to merge though. * Adds `noir-packages` job to build the ts packages. * Fix `sed` use in bb.js to work on Mac. * Bootstrap scripts for noir, call it from bootstrap.sh. * Fix to `build_local`. * Use the noir bootstrap scripts to build the docker containers. * `yarn-project` now builds the protocol circuits from the noir build in bootstrap and dockerfile. * `yarn-project` portals the noir packages in. **What does this mean for releases!?* * Fixes as we're now on noir 19. * Remove `noir-protocol-circuits/src/target` from repo as they're now built. * Bootstrap improvements: * Defaults to a "lighter" bootstrap. * `bootstrap.sh clean` resets repo to as if fresh clone. (be careful). * Introduces ability to test the bootstrap process via a docker container. (might add a nightly job, plus alternative ubuntu releases).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is here simply to provide something cleaner to review, otherwise we see all the noir pull changes.
Actual passing PR to review is here: #3420
noir-packagesjob to build the ts packages.seduse in bb.js to work on Mac.build_local.yarn-projectnow builds the protocol circuits from the noir build in bootstrap and dockerfile.yarn-projectportals the noir packages in. *What does this mean for releases!?noir-protocol-circuits/src/targetfrom repo as they're now built.bootstrap.sh cleanresets repo to as if fresh clone. (be careful).