Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: documenting issue with context.block_header #3565

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Dec 5, 2023

I was incorrectly trying to fetch a sibling path from an older block when proving that a block header is legit. This caused the test to break when proving inclusion at an older block. I currently could not address it because of issue #3564 so I decided to only document it in this PR.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@AztecBot
Copy link
Collaborator

AztecBot commented Dec 5, 2023

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (32): 160 (+159%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9f682cb8 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 223,008 868,100 3,449,504
l1_rollup_execution_gas 842,095 3,595,208 22,204,873
l2_block_processing_time_in_ms 2,247 (+1%) 8,630 35,717 (+1%)
note_successful_decrypting_time_in_ms 323 (+3%) 975 (+4%) 3,497
note_trial_decrypting_time_in_ms 32.9 (+23%) ⚠️ 160 (+159%) 200 (-1%)
l2_block_building_time_in_ms 20,696 (+1%) 82,061 328,251 (+1%)
l2_block_rollup_simulation_time_in_ms 17,110 (+2%) 67,942 271,618 (+1%)
l2_block_public_tx_process_time_in_ms 3,537 (+1%) 13,966 (+1%) 56,062

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 24,720 (-2%) 47,666 (-2%)
note_history_successful_decrypting_time_in_ms 2,161 (-5%) 4,167 (-6%)
note_history_trial_decrypting_time_in_ms 162 (-2%) 231
node_database_size_in_bytes 2,786,576 5,018,203
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 200 43,109 20,441
private-kernel-ordering 115 25,833 9,689
base-rollup 2,963 664,108 873
root-rollup 84.8 (-8%) 4,072 881
private-kernel-inner 261 64,516 20,441
public-kernel-private-input 172 25,203 20,441
public-kernel-non-first-iteration 169 25,245 20,441
merge-rollup 11.1 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 10,323 25,938

@benesjan benesjan merged commit 1237e26 into master Dec 5, 2023
83 checks passed
@benesjan benesjan deleted the janb/documenting-issue branch December 5, 2023 14:22
rahul-kothari pushed a commit that referenced this pull request Dec 5, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.16.3</summary>

##
[0.16.3](aztec-packages-v0.16.2...aztec-packages-v0.16.3)
(2023-12-05)


### Miscellaneous

* CLI's startup time was pushing almost 2s. This gets the basic 'help'
down to 0.16.
([#3529](#3529))
([396df13](396df13))


### Documentation

* Documenting issue with `context.block_header`
([#3565](#3565))
([1237e26](1237e26))
</details>

<details><summary>barretenberg.js: 0.16.3</summary>

##
[0.16.3](barretenberg.js-v0.16.2...barretenberg.js-v0.16.3)
(2023-12-05)


### Miscellaneous

* CLI's startup time was pushing almost 2s. This gets the basic 'help'
down to 0.16.
([#3529](#3529))
([396df13](396df13))
</details>

<details><summary>barretenberg: 0.16.3</summary>

##
[0.16.3](barretenberg-v0.16.2...barretenberg-v0.16.3)
(2023-12-05)


### Miscellaneous

* CLI's startup time was pushing almost 2s. This gets the basic 'help'
down to 0.16.
([#3529](#3529))
([396df13](396df13))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Dec 6, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.16.3</summary>

##
[0.16.3](AztecProtocol/aztec-packages@aztec-packages-v0.16.2...aztec-packages-v0.16.3)
(2023-12-05)


### Miscellaneous

* CLI's startup time was pushing almost 2s. This gets the basic 'help'
down to 0.16.
([#3529](AztecProtocol/aztec-packages#3529))
([396df13](AztecProtocol/aztec-packages@396df13))


### Documentation

* Documenting issue with `context.block_header`
([#3565](AztecProtocol/aztec-packages#3565))
([1237e26](AztecProtocol/aztec-packages@1237e26))
</details>

<details><summary>barretenberg.js: 0.16.3</summary>

##
[0.16.3](AztecProtocol/aztec-packages@barretenberg.js-v0.16.2...barretenberg.js-v0.16.3)
(2023-12-05)


### Miscellaneous

* CLI's startup time was pushing almost 2s. This gets the basic 'help'
down to 0.16.
([#3529](AztecProtocol/aztec-packages#3529))
([396df13](AztecProtocol/aztec-packages@396df13))
</details>

<details><summary>barretenberg: 0.16.3</summary>

##
[0.16.3](AztecProtocol/aztec-packages@barretenberg-v0.16.2...barretenberg-v0.16.3)
(2023-12-05)


### Miscellaneous

* CLI's startup time was pushing almost 2s. This gets the basic 'help'
down to 0.16.
([#3529](AztecProtocol/aztec-packages#3529))
([396df13](AztecProtocol/aztec-packages@396df13))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants