feat!: deduplicating circuit types + typing everything

[benesjan]

Fixes #3592
Fixes #3059

DON'T MERGE BEFORE RELEASE ON 13.12.2023

Issues which I created based on this PR:

1. Fix the #[event] macro (I broke it) #3655
2. Update compute_note_hash_and_nullifier compiler check to accept AztecAddress type #3669

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9ccbbd96 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,912	868,148	3,449,312
l1_rollup_execution_gas	841,999	3,595,256	22,204,681
l2_block_processing_time_in_ms	2,222	8,542 (+1%)	35,445
note_successful_decrypting_time_in_ms	358	1,079 (+3%)	3,958 (+2%)
note_trial_decrypting_time_in_ms	88.4 (+25%)	41.0 (+3%)	140 (+1%)
l2_block_building_time_in_ms	20,274	80,958 (+1%)	323,509
l2_block_rollup_simulation_time_in_ms	16,701	66,760 (+1%)	267,011
l2_block_public_tx_process_time_in_ms	3,541 (+1%)	14,127 (+2%)	56,182 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	24,749 (-1%)	47,954 (-1%)
note_history_successful_decrypting_time_in_ms	2,598 (-3%)	5,310 (+1%)
note_history_trial_decrypting_time_in_ms	72.9 (-20%)	147 (-3%)
node_database_size_in_bytes	3,629,211	3,910,989
pxe_database_size_in_bytes	29,940	59,499

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	200	43,109	20,441
private-kernel-ordering	115	25,833	9,689
base-rollup	2,973	667,692	873
root-rollup	94.0 (+4%)	4,072	881
private-kernel-inner	261	64,516	20,441
public-kernel-private-input	172	25,203	20,441
public-kernel-non-first-iteration	171 (+1%)	25,245	20,441
merge-rollup	11.0 (+1%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	10,323	26,359 (+2%)

[LHerskind]

Generally love it, added a few comments. Good interim work around for the compute_note_hash_and_nullifier, while it will be out of sync for noir.

[LHerskind]

@kevaundray if contract was to be removed from Noir as a keyword, and used in macros instead, I guess we could be renaming that folder and its content to use a proper spelling?

[kevaundray]

It depends on what we go with as an alternative, the short term change might be to just change it to #[contract] which would not get rid of it

[LHerskind]

How much of this will actually be living in here and not end up in the protocol circuits. Is this really aztec-nr specific or protocol specific 🤔.

I guess it is mainly aztec-nr that is just using everything that we got from the protocol to setup the context, but it would be possible to change it for other libraries etc.