Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hashing to stdlib transcript #4161

Merged
merged 81 commits into from
Feb 8, 2024
Merged

feat: add hashing to stdlib transcript #4161

merged 81 commits into from
Feb 8, 2024

Commits on Jan 13, 2024

  1. added poseidon2 to native transcript

    @lucasxia01
    lucasxia01 committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    29a0d28 View commit details
    Browse the repository at this point in the history

  2. wip

    @lucasxia01
    lucasxia01 committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    61c9eca View commit details
    Browse the repository at this point in the history

  3. removed grumpkin poseidon2 params

    @lucasxia01
    lucasxia01 committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    a8204fb View commit details
    Browse the repository at this point in the history

  4. removed transcript template param, 

    shoudl only be barretenberg::fr for now
    @lucasxia01
    lucasxia01 committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    05085c5 View commit details
    Browse the repository at this point in the history

  5. removing poseidon2 grumpkin 

    updated challenges to be uint256_t for now
    @lucasxia01
    lucasxia01 committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    99bd01d View commit details
    Browse the repository at this point in the history

  6. removed template param from honk::proof

    @lucasxia01
    lucasxia01 committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    029350c View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. linker error be gone among other merge errors

    @lucasxia01
    lucasxia01 committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    a045b6d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. conversions

    @lucasxia01
    lucasxia01 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    86065bc View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. updated calc_num_frs() with all transcript types

    @lucasxia01
    lucasxia01 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d50ac92 View commit details
    Browse the repository at this point in the history

  2. completed convert_to_bn254_frs for various transcript types

    @lucasxia01
    lucasxia01 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5f46e2d View commit details
    Browse the repository at this point in the history

  3. convert_from_bn254_frs initial impl updated

    @lucasxia01
    lucasxia01 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d157087 View commit details
    Browse the repository at this point in the history

  4. fixing bugs (wip)

    @lucasxia01
    lucasxia01 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f769528 View commit details
    Browse the repository at this point in the history

  5. hacky solution to templating to get things to compile

    @lucasxia01
    lucasxia01 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e8702c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. checking if CI tests still fail

    @lucasxia01
    lucasxia01 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    86eae85 View commit details
    Browse the repository at this point in the history

  2. fixed bugs in conversions

    @lucasxia01
    lucasxia01 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    4a04326 View commit details
    Browse the repository at this point in the history

  3. added (partial) unit tests

    @lucasxia01
    lucasxia01 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2d16e5d View commit details
    Browse the repository at this point in the history

  4. updated structuring and tests

    @lucasxia01
    lucasxia01 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2c6406d View commit details
    Browse the repository at this point in the history

  5. temporary "fix" to ci gcc compile error

    @lucasxia01
    lucasxia01 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c0c715c View commit details
    Browse the repository at this point in the history

  6. cleaning up field conversion calc_num_frs style

    @lucasxia01
    lucasxia01 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    dd3366c View commit details
    Browse the repository at this point in the history

  7. undo challenge fix

    @lucasxia01
    lucasxia01 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    b37bed8 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. pushing linker error

    @lucasxia01
    lucasxia01 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    09f7ea2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into lx/transcript-native-field-refactor

    @lucasxia01
    lucasxia01 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    7346629 View commit details
    Browse the repository at this point in the history

  3. changed to bb::

    @lucasxia01
    lucasxia01 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    1484030 View commit details
    Browse the repository at this point in the history

  4. inline + comments + cleanup

    @lucasxia01
    lucasxia01 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    97c2f88 View commit details
    Browse the repository at this point in the history

  5. completed tests, small updates

    @lucasxia01
    lucasxia01 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    e2f7526 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into lx/transcript-native-field-refactor

    @lucasxia01
    lucasxia01 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f67148d View commit details
    Browse the repository at this point in the history

  7. initial stdlib conversions

    @lucasxia01
    lucasxia01 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0a8b2fc View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. templated transcript

    @lucasxia01
    lucasxia01 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6bc91fb View commit details
    Browse the repository at this point in the history

  2. reomving unnecessary cmake stuff

    @lucasxia01
    lucasxia01 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c0b5fb6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into lx/transcript-native-field-refactor

    @lucasxia01
    lucasxia01 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    d3e110b View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Merge branch 'master' into lx/transcript-native-field-refactor

    @lucasxia01
    lucasxia01 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    330c0c8 View commit details
    Browse the repository at this point in the history

  2. fix?

    @lucasxia01
    lucasxia01 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7fd7553 View commit details
    Browse the repository at this point in the history

  3. cbind fix fix

    @lucasxia01
    lucasxia01 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    bbfb92b View commit details
    Browse the repository at this point in the history

  4. undo

    @lucasxia01
    lucasxia01 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    a53a144 View commit details
    Browse the repository at this point in the history

  5. maybe cbind fix

    @lucasxia01
    lucasxia01 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e12cb61 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. cbind fix for real this time

    @lucasxia01
    lucasxia01 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    fe43adf View commit details
    Browse the repository at this point in the history

  2. wip conversions

    @lucasxia01
    lucasxia01 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    1b9416d View commit details
    Browse the repository at this point in the history

  3. fixed error caused by overfixing

    @lucasxia01
    lucasxia01 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b1d5678 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into lx/transcript-native-field-refactor

    @lucasxia01
    lucasxia01 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    cab1312 View commit details
    Browse the repository at this point in the history

  5. fixed merge conflicts with protogalaxy, decider recursive verifiers

    @lucasxia01
    lucasxia01 committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    54bb864 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. new stdlib field conversion functions

    @lucasxia01
    lucasxia01 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c75735d View commit details
    Browse the repository at this point in the history

  2. gcc typename fix

    @lucasxia01
    lucasxia01 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    cc5fce9 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. adding stdlib transcript into the ONE transcript 

    includes the proper challenge conversions instead of just using uint256
    @lucasxia01
    lucasxia01 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    cd5049e View commit details
    Browse the repository at this point in the history

  2. type check fix demanded by wasm clang

    @lucasxia01
    lucasxia01 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c4375d3 View commit details
    Browse the repository at this point in the history

  3. fixed constructor (sorta hacky)

    @lucasxia01
    lucasxia01 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4c022f0 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. added testing, updated conversion

    @lucasxia01
    lucasxia01 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    610d6b6 View commit details
    Browse the repository at this point in the history

  2. updated conversion for grumpkin fr

    @lucasxia01
    lucasxia01 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    9cc55d1 View commit details
    Browse the repository at this point in the history

  3. responded to PR comments, refactored, added comments

    @lucasxia01
    lucasxia01 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    87078b3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'lx/transcript-native-field-refactor' into lx/transcript… 

    …-stdlib-hashing
    @lucasxia01
    lucasxia01 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    1fbf9e2 View commit details
    Browse the repository at this point in the history

  5. update everything to new transcript

    @lucasxia01
    lucasxia01 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2d6eca7 View commit details
    Browse the repository at this point in the history

  6. small fix, uint64_t -> uint256_t to dodge overflow

    @lucasxia01
    lucasxia01 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    f75cca3 View commit details
    Browse the repository at this point in the history

  7. fix to ipa transcript usage

    @lucasxia01
    lucasxia01 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    0c9bb81 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. fixed two bugs: 

    one where I wasn't creating witnesses out of the transcript
one where restoring finalize failed to resize additional selectors
    @lucasxia01
    lucasxia01 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e86d026 View commit details
    Browse the repository at this point in the history

  2. small style updates

    @lucasxia01
    lucasxia01 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    850ec4d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'lx/transcript-native-field-refactor' into lx/transcript… 

    …-stdlib-hashing
    @lucasxia01
    lucasxia01 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    85c92df View commit details
    Browse the repository at this point in the history

  4. update to ipa poly degree type: uint64_t -> uint32_t

    @lucasxia01
    lucasxia01 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    adfa3d3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into lx/transcript-native-field-refactor

    @lucasxia01
    lucasxia01 authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9f6293c View commit details
    Browse the repository at this point in the history

  6. updated merged in code

    @lucasxia01
    lucasxia01 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    777e8b1 View commit details
    Browse the repository at this point in the history

  7. updated protogalaxy cmakelists

    @lucasxia01
    lucasxia01 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    de5b619 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'lx/transcript-native-field-refactor' into lx/transcript… 

    …-stdlib-hashing
    @lucasxia01
    lucasxia01 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    efb5d18 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Merge commit 'afcfa71da760680dfe02c39cf2de068a4297b3e7' into lx/trans… 

    …cript-stdlib-hashing
    @lucasxia01
    lucasxia01 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    407d802 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into lx/transcript-stdlib-hashing

    @lucasxia01
    lucasxia01 authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    6a0ee73 View commit details
    Browse the repository at this point in the history

  3. simplication of functions using bigfield constructor

    @lucasxia01
    lucasxia01 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2ca5fee View commit details
    Browse the repository at this point in the history

  4. updates to stdlib field conversion tests

    @lucasxia01
    lucasxia01 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ab52a67 View commit details
    Browse the repository at this point in the history

  5. test fix

    @lucasxia01
    lucasxia01 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    22b3f56 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into lx/transcript-stdli… 

    …b-hashing
    @lucasxia01
    lucasxia01 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7fb693c View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Merge remote-tracking branch 'origin/master' into lx/transcript-stdli… 

    …b-hashing
    @codygunton
    codygunton committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f376c16 View commit details
    Browse the repository at this point in the history

  2. Fix GCC

    @codygunton
    codygunton committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    1586230 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into lx/transcript-stdli… 

    …b-hashing
    @codygunton
    codygunton committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    81279e9 View commit details
    Browse the repository at this point in the history

  4. Revert scratch

    @codygunton
    codygunton committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    33940e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. updated stdlib grumpkin element conversion and refactored

    @lucasxia01
    lucasxia01 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8d89cc1 View commit details
    Browse the repository at this point in the history

  2. delete the existing stdlib transcript

    @lucasxia01
    lucasxia01 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    be52ead View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. addressing minor comments

    @lucasxia01
    lucasxia01 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    38d6909 View commit details
    Browse the repository at this point in the history

  2. fixed dependencies to remove cycle

    @lucasxia01
    lucasxia01 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    123abba View commit details
    Browse the repository at this point in the history

  3. removed no op functions in arithmetization

    @lucasxia01
    lucasxia01 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    cdbb894 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. added tests for converting challenges, 

    modified convert_to_grumpkin_fr
    @lucasxia01
    lucasxia01 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a8765e4 View commit details
    Browse the repository at this point in the history

  2. changed evaluate_linear_identity to assert_equal

    @lucasxia01
    lucasxia01 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    69d9bde View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into lx/transcript-stdlib-hashing

    @lucasxia01
    lucasxia01 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4b007e1 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into lx/transcript-stdli… 

    …b-hashing
    @lucasxia01
    lucasxia01 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c3f3d94 View commit details
    Browse the repository at this point in the history

  5. added TODO comments

    @lucasxia01
    lucasxia01 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a7e6559 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into lx/transcript-stdlib-hashing

    @lucasxia01
    lucasxia01 authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5963b98 View commit details
    Browse the repository at this point in the history