chore: remove .oldValue in contract state update request

[Maddiaa0]

Please read contributing guidelines and remove this line.

[Maddiaa0]

Current dependencies on/for this PR:

• master
  • PR feat(avm): introduce small e2e test  #4470
    • PR chore: remove .oldValue in contract state update request #4499 👈

This stack of pull requests is managed by Graphite.

[github-actions]

Changes to circuit sizes

Generated at commit: 6d819aa40098005a5e21e6782e17c3890de5ae04, compared to commit: da2f5ed3fee642550addf92049a7b21e07938222

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_inner	-16 ✅	-0.02%	-32 ✅	-0.01%
private_kernel_init	-16 ✅	-0.04%	-32 ✅	-0.01%
public_kernel_app_logic_simulated	-16 ✅	-1.84%	-32 ✅	-1.84%
public_kernel_setup_simulated	-16 ✅	-1.84%	-32 ✅	-1.84%
private_kernel_inner_simulated	-16 ✅	-1.96%	-32 ✅	-1.95%
private_kernel_init_simulated	-16 ✅	-1.96%	-32 ✅	-1.95%
public_kernel_setup	-2,379 ✅	-5.02%	-10,253 ✅	-4.05%
public_kernel_app_logic	-2,379 ✅	-5.02%	-10,253 ✅	-4.05%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_inner	93,263 (-16)	-0.02%	522,659 (-32)	-0.01%
private_kernel_init	36,330 (-16)	-0.04%	331,113 (-32)	-0.01%
public_kernel_app_logic_simulated	852 (-16)	-1.84%	1,707 (-32)	-1.84%
public_kernel_setup_simulated	852 (-16)	-1.84%	1,707 (-32)	-1.84%
private_kernel_inner_simulated	801 (-16)	-1.96%	1,605 (-32)	-1.95%
private_kernel_init_simulated	801 (-16)	-1.96%	1,605 (-32)	-1.95%
public_kernel_setup	44,982 (-2,379)	-5.02%	242,825 (-10,253)	-4.05%
public_kernel_app_logic	44,974 (-2,379)	-5.02%	242,817 (-10,253)	-4.05%

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit acf5cf23 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,700	180,580	720,100
l1_rollup_calldata_gas	222,616	871,312	3,465,940
l1_rollup_execution_gas	315,807	989,760	3,686,318
l2_block_processing_time_in_ms	1,183 (+3%)	4,371 (+1%)	17,347 (+1%)
note_successful_decrypting_time_in_ms	321 (+2%)	983	3,673
note_trial_decrypting_time_in_ms	31.8 (+25%)	110 (+3%)	149 (+1%)
l2_block_building_time_in_ms	18,307	72,103	290,295
l2_block_rollup_simulation_time_in_ms	13,586 (+1%)	53,460 (+1%)	215,788 (+1%)
l2_block_public_tx_process_time_in_ms	4,692 (-3%)	18,562 (-3%)	74,244 (-3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,088 (+1%)	29,117 (+1%)
note_history_successful_decrypting_time_in_ms	2,529	4,692 (-4%)
note_history_trial_decrypting_time_in_ms	139 (+55%)	189 (+20%)
node_database_size_in_bytes	17,334,352	33,071,184
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	307	44,528	25,313 (-2%)
private-kernel-ordering	197	43,633 (-1%)	16,193
base-rollup	1,460 (+1%)	129,774	933
root-rollup	83.6 (-1%)	4,192	729
private-kernel-inner	435	70,819 (-1%)	25,313 (-2%)
public-kernel-private-input	239 (-4%)	33,663 (-3%)	26,945 (-2%)
public-kernel-non-first-iteration	239 (-4%)	33,705 (-3%)	26,945 (-2%)
merge-rollup	7.98 (+2%)	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3 (+1%)	11.7 (+10%)	12.9	17.3 (+4%)	23.0 (+1%)	65.4 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.597	0.651 (+10%)	0.547	0.536 (+3%)	0.481 (+1%)	0.449 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	81.0 (+9%)	47.9 (+1%)	243	462	903 (+1%)	3,579 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.499 (+9%)	0.491 (+1%)	0.442 (+1%)	0.432	0.429	0.429 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	109 (+6%)	57.0 (+1%)	357 (+3%)	695 (+1%)	1,370 (+1%)	5,441 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.514 (+5%)	0.499 (+1%)	0.485 (+2%)	0.477 (+1%)	0.475 (+1%)	0.473 (+1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	57.0 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.582	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	16,827	39,778 (-1%)

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	555	1,313

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.526 (+8%)	576 (-3%)

[sirasistant]

Thanks for the cleanup! :D