-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add versions section to updating doc #4916
Conversation
26771de
to
23cc094
Compare
Docs PreviewHey there! 👋 You can check your preview at https://65e8af2af661f12d6146a738--aztec-docs-dev.netlify.app |
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contracts are deployed in the tx.
Transaction processing duration by data writes.
|
|
||
### Checking tool versions | ||
To check your version of Aztec tools, you can use `aztec-cli -V` | ||
::note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
::note | |
:::note |
:::note | ||
|
||
That is, BEFORE `aztec-packages-v0.24.0`: | ||
`aztec = { git="https://github.com/AztecProtocol/aztec-packages/", tag="aztec-packages-v0.23.0", directory="yarn-project/aztec-nr/aztec" }` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`aztec = { git="https://github.com/AztecProtocol/aztec-packages/", tag="aztec-packages-v0.23.0", directory="yarn-project/aztec-nr/aztec" }` | |
```toml | |
aztec = { git="https://github.com/AztecProtocol/aztec-packages/", tag="aztec-packages-v0.23.0", directory="yarn-project/aztec-nr/aztec" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting got weird because the suggestion is delineated with three back ticks . just need to make sure the code block is closed with three
That is, BEFORE `aztec-packages-v0.24.0`: | ||
`aztec = { git="https://github.com/AztecProtocol/aztec-packages/", tag="aztec-packages-v0.23.0", directory="yarn-project/aztec-nr/aztec" }` | ||
At/after `aztec-packages-v0.24.0`: | ||
`aztec = { git="https://github.com/AztecProtocol/aztec-packages/", tag="aztec-packages-v0.24.0", directory="noir-projects/aztec-nr/aztec" }` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`aztec = { git="https://github.com/AztecProtocol/aztec-packages/", tag="aztec-packages-v0.24.0", directory="noir-projects/aztec-nr/aztec" }` | |
```toml | |
aztec = { git="https://github.com/AztecProtocol/aztec-packages/", tag="aztec-packages-v0.24.0", directory="noir-projects/aztec-nr/aztec" } |
`aztec = { git="https://github.com/AztecProtocol/aztec-packages/", tag="aztec-packages-v0.24.0", directory="noir-projects/aztec-nr/aztec" }` | ||
|
||
### Example contract versions | ||
Example contracts serve as an especially helpful reference between versions of the aztec-nr framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example contracts serve as an especially helpful reference between versions of the aztec-nr framework. | |
Example contracts serve as a helpful reference between versions of the aztec-nr framework. |
### Example contract versions | ||
Example contracts serve as an especially helpful reference between versions of the aztec-nr framework. | ||
|
||
Code referenced in the documentation is sourced from a directory in the `aztec-packages` repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe link directly to this directory, since you mention it.
|
||
### Language server version (nargo) | ||
The [Noir LSP](https://docs.aztec.network/developers/contracts/main#install-noir-lsp-recommended) uses your local version of `aztec-nargo`, and thus also `aztec-nargo compile`. | ||
The path of the former (once installed) can be seen by hovering over "Nargo" in the bottom status bar, and the latter via `which aztec-nargo`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path of the former (once installed) can be seen by hovering over "Nargo" in the bottom status bar, and the latter via `which aztec-nargo`. | |
The path of the former (once installed) can be seen by hovering over "Nargo" in the bottom status bar of VS Code, and the latter via the `which aztec-nargo` command. |
This can present confusion when opening older noir contracts (and dependencies), such as: | ||
- Logs filled with errors from the dependencies | ||
- Or the LSP fails (re-runs automatically then stops) | ||
The second point requires a restart of the extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second point requires a restart of the extension. | |
The second point requires a restart of the extension, which you can trigger with Ctrl + Shift + P and typing "Reload Window". |
The second point requires a restart of the extension. | ||
|
||
:::tip | ||
When using the LSP in VSCode, reference older versions of Noir code in a separate window or a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does a separate window help? Doesn't the LSP always use locally installed version of nargo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using the correct version of aztec-nargo with the correct version of your code, all is well. If you happen to open an older versioned contract, and unlucky to hit some error with aztec-nargo and that code version, then vscode will try rerun the extension. This happens 5 times before the extension decides to stop trying.
At that point, even if you close the older example, you'll have to restart Noir LSP extension in the window.
To prevent this scenario the suggestion is to keep your primary window pure, and reference the old code elsewhere. If in another vscode window (not tab), the main window's extension is fine.
Happy to drop this since the "tip" tag is overly prominent for this minor/low-probability devexp optimisation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit regarding "show don't tell" 👍
Check the `git=` github url, tag, and directory. | ||
|
||
:::note | ||
The folder structure changed at **0.24.0** from `yarn-project/aztec-nr` to `noir-projects/aztec-nr`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mentioned in the migration notes page. Consider linking there to reduce redundant information. Any developers coming after v0.24 don't need to see this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could remove all of the following lines until ### Example contract versions
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.5</summary> ## [0.26.5](aztec-package-v0.26.4...aztec-package-v0.26.5) (2024-03-07) ### Features * Integrated native ACVM ([#4903](#4903)) ([3fd7025](3fd7025)) </details> <details><summary>barretenberg.js: 0.26.5</summary> ## [0.26.5](barretenberg.js-v0.26.4...barretenberg.js-v0.26.5) (2024-03-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.5</summary> ## [0.26.5](aztec-cli-v0.26.4...aztec-cli-v0.26.5) (2024-03-07) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.26.5</summary> ## [0.26.5](aztec-packages-v0.26.4...aztec-packages-v0.26.5) (2024-03-07) ### Features * Crowdfunding contract ([#4917](#4917)) ([ba3aff2](ba3aff2)) * Integrated native ACVM ([#4903](#4903)) ([3fd7025](3fd7025)) ### Bug Fixes * Dependency for yarn-project-tests ([#5031](#5031)) ([4b5db50](4b5db50)) * **docs:** Update writing_token_contract.md ([#5020](#5020)) ([5b0f38f](5b0f38f)) * End to end dependency fix ([#5029](#5029)) ([191ad93](191ad93)) * Missing dependency end-to-end => yarn-project ([#5018](#5018)) ([f930bdd](f930bdd)) * **revert:** "feat(avm): storage" ([#5019](#5019)) ([ba31016](ba31016)) ### Miscellaneous * **boxes:** Refactor npx to improve readability, added upgrade option and manual versioning ([#4855](#4855)) ([ef76d3f](ef76d3f)) * Purging calldata hash ([#4984](#4984)) ([f6f34b7](f6f34b7)) ### Documentation * Add versions section to updating doc ([#4916](#4916)) ([d4d935f](d4d935f)) </details> <details><summary>barretenberg: 0.26.5</summary> ## [0.26.5](barretenberg-v0.26.4...barretenberg-v0.26.5) (2024-03-07) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@aztec-package-v0.26.4...aztec-package-v0.26.5) (2024-03-07) ### Features * Integrated native ACVM ([#4903](AztecProtocol/aztec-packages#4903)) ([3fd7025](AztecProtocol/aztec-packages@3fd7025)) </details> <details><summary>barretenberg.js: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@barretenberg.js-v0.26.4...barretenberg.js-v0.26.5) (2024-03-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@aztec-cli-v0.26.4...aztec-cli-v0.26.5) (2024-03-07) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@aztec-packages-v0.26.4...aztec-packages-v0.26.5) (2024-03-07) ### Features * Crowdfunding contract ([#4917](AztecProtocol/aztec-packages#4917)) ([ba3aff2](AztecProtocol/aztec-packages@ba3aff2)) * Integrated native ACVM ([#4903](AztecProtocol/aztec-packages#4903)) ([3fd7025](AztecProtocol/aztec-packages@3fd7025)) ### Bug Fixes * Dependency for yarn-project-tests ([#5031](AztecProtocol/aztec-packages#5031)) ([4b5db50](AztecProtocol/aztec-packages@4b5db50)) * **docs:** Update writing_token_contract.md ([#5020](AztecProtocol/aztec-packages#5020)) ([5b0f38f](AztecProtocol/aztec-packages@5b0f38f)) * End to end dependency fix ([#5029](AztecProtocol/aztec-packages#5029)) ([191ad93](AztecProtocol/aztec-packages@191ad93)) * Missing dependency end-to-end => yarn-project ([#5018](AztecProtocol/aztec-packages#5018)) ([f930bdd](AztecProtocol/aztec-packages@f930bdd)) * **revert:** "feat(avm): storage" ([#5019](AztecProtocol/aztec-packages#5019)) ([ba31016](AztecProtocol/aztec-packages@ba31016)) ### Miscellaneous * **boxes:** Refactor npx to improve readability, added upgrade option and manual versioning ([#4855](AztecProtocol/aztec-packages#4855)) ([ef76d3f](AztecProtocol/aztec-packages@ef76d3f)) * Purging calldata hash ([#4984](AztecProtocol/aztec-packages#4984)) ([f6f34b7](AztecProtocol/aztec-packages@f6f34b7)) ### Documentation * Add versions section to updating doc ([#4916](AztecProtocol/aztec-packages#4916)) ([d4d935f](AztecProtocol/aztec-packages@d4d935f)) </details> <details><summary>barretenberg: 0.26.5</summary> ## [0.26.5](AztecProtocol/aztec-packages@barretenberg-v0.26.4...barretenberg-v0.26.5) (2024-03-07) ### Miscellaneous * **barretenberg:** Synchronize aztec-packages versions </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.