feat: Updating an SMT solver class #4981

Sarkoxed · 2024-03-06T12:24:40Z

This pr mostly adds more functionality to smt_solver::Solver class, including

new options to cvc5 solver config, including verbosity increase and finite field solver choice
default_solver_config constant so you don't need to initialize it each time
print_assertions method that converts smt lang to something more readable and outputs it
tests for solver class

Also it updates and fixes the symbolic terms classes:

^ operation is no longer viable with FFITerm, since they are not compatible
!= operation now uses boolean NOT instead of equating the whole term to false
std::string method now uses smt_solver::stringify_term
! operator was added to Bool class

Added - new options to cvc5 solver config - `default_solver_config` constant so you don't need to initialize it each time - `print_assertions` method that converts smt lang to something more readable - tests for solver class

- Changed `^` opeartor in FFITerm since it's not compatible with integers - Changed `!=` operator so it now uses boolean not instead of `== false` - Updated `std::string` method, so it now uses my new `stringify_term` function - Added `!` operator to symbolic Bool class

barretenberg/cpp/src/barretenberg/smt_verification/solver/solver.cpp

Rumata888 · 2024-03-06T13:56:06Z

barretenberg/cpp/src/barretenberg/smt_verification/solver/solver.hpp

+        }
+
+        if (config.ff_disjunctive_bit) {
+            s.setOption("ff-disjunctive-bit", "true");


Could you add a comment, when this can be useful?

Rumata888 · 2024-03-06T13:56:29Z

barretenberg/cpp/src/barretenberg/smt_verification/solver/solver.hpp

+            s.setOption("ff-disjunctive-bit", "true");
+        }
+        if (!config.ff_solver.empty()) {
+            s.setOption("ff-solver", config.ff_solver);


Could you explain what is the difference and how it would affect the results?

Rumata888

Looks good. Please address my comments and then you can merge

AztecBot · 2024-03-06T14:35:36Z

Benchmark results

Metrics with a significant change:

note_trial_decrypting_time_in_ms (8): 111 (+503%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f3d9f9b5 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,528	239,444	470,288
l1_rollup_execution_gas	673,991	980,265	1,389,062
l2_block_processing_time_in_ms	1,165 (-3%)	4,410 (+1%)	8,730 (-2%)
note_successful_decrypting_time_in_ms	198 (-7%)	539	978 (-1%)
note_trial_decrypting_time_in_ms	⚠️ 111 (+503%)	56.1 (+1%)	110 (-18%)
l2_block_building_time_in_ms	11,817 (-2%)	47,068 (-1%)	94,042 (-2%)
l2_block_rollup_simulation_time_in_ms	7,189 (-2%)	28,745 (-2%)	57,634 (-2%)
l2_block_public_tx_process_time_in_ms	4,600 (-2%)	18,255 (-1%)	36,266 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,576 (+10%)	27,320 (+3%)
note_history_successful_decrypting_time_in_ms	1,253	2,416 (+1%)
note_history_trial_decrypting_time_in_ms	99.6 (+9%)	130 (-2%)
node_database_size_in_bytes	18,751,568	35,524,688
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	251 (-1%)	44,736	28,001
private-kernel-ordering	194	52,625	14,627
base-rollup	654 (-1%)	177,932	997
root-rollup	68.5 (-1%)	4,320	825
private-kernel-inner	317 (-1%)	73,715	28,001
public-kernel-app-logic	163 (-1%)	34,920	27,972
public-kernel-tail	81.4 (-1%)	34,507	27,972
merge-rollup	8.46	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.93 (+1%)	10.4 (-3%)	14.8 (+19%)	16.4 (+2%)	21.4 (-1%)	34.3 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.575 (+1%)	0.581 (-3%)	0.629 (+19%)	0.506 (+2%)	0.449 (-1%)	0.428 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	46.4 (+2%)	71.3	227 (-2%)	449 (+1%)	858 (+2%)	1,690 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.475 (+1%)	0.440	0.415 (-1%)	0.419 (+1%)	0.408 (+2%)	0.405 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	53.6	105 (-1%)	332 (-2%)	665 (+1%)	1,286 (+1%)	2,536 (-3%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.478	0.475	0.449 (-3%)	0.457	0.446	0.440 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.3 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.535	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,671 (-1%)	1,369

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	6.57 (+23%)	569 (-1%)

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.6</summary> ## [0.26.6](aztec-package-v0.26.5...aztec-package-v0.26.6) (2024-03-08) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.26.6</summary> ## [0.26.6](barretenberg.js-v0.26.5...barretenberg.js-v0.26.6) (2024-03-08) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.6</summary> ## [0.26.6](aztec-cli-v0.26.5...aztec-cli-v0.26.6) (2024-03-08) ### Features * Show bytecode size per function in CLI inspect-contract ([#5059](#5059)) ([cb9fdc6](cb9fdc6)) </details> <details><summary>aztec-packages: 0.26.6</summary> ## [0.26.6](aztec-packages-v0.26.5...aztec-packages-v0.26.6) (2024-03-08) ### Features * Basic public reverts ([#4870](#4870)) ([5cccc78](5cccc78)) * Deploying new inbox ([#5036](#5036)) ([fed729d](fed729d)) * Detect unknown note type ids in compute_note_hash ([#5086](#5086)) ([6206bec](6206bec)) * Easy deployment of protocol contracts in e2e ([#4983](#4983)) ([480161f](480161f)) * IPA documentation ([#4924](#4924)) ([48bd22e](48bd22e)) * Nullifier read requests in public kernel ([#4910](#4910)) ([0e44247](0e44247)) * Show bytecode size per function in CLI inspect-contract ([#5059](#5059)) ([cb9fdc6](cb9fdc6)) * Updating an SMT solver class ([#4981](#4981)) ([4b94d58](4b94d58)) ### Bug Fixes * Canonical contract address ([#5030](#5030)) ([b2af880](b2af880)) * Flaky deployment test ([#5035](#5035)) ([039eafc](039eafc)) * Pull the correct platform image for noir ([#5097](#5097)) ([3342371](3342371)) * Sleep function memory leak ([#5023](#5023)) ([a72cfea](a72cfea)), closes [#4817](#4817) * Storage v2 ([#5027](#5027)) ([fe3190e](fe3190e)) * Update protogalaxy cmake dependencies ([#5066](#5066)) ([507c374](507c374)) ### Miscellaneous * Address warnings in noir test suite ([#4966](#4966)) ([7ef4ef5](7ef4ef5)) * Bootstrap noir natively if nargo is invalid ([#5034](#5034)) ([df089de](df089de)) * Build avm transpiler if we are on mac ([#5039](#5039)) ([c2966b9](c2966b9)) * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](#5065)) ([58e1ff4](58e1ff4)) * Cleanup of prover and verifier instances ([#4959](#4959)) ([f2fdefd](f2fdefd)) * Delete bootstrap scripts from `noir/noir-repo` ([#5044](#5044)) ([add91ca](add91ca)) * Disable `hello_world_example` noir test in aztec-packages CI ([#5061](#5061)) ([1be9243](1be9243)) * Join-split example Part 1 ([#4965](#4965)) ([b9de0f5](b9de0f5)) * Moving RootRollupInputs impl ([#5087](#5087)) ([f3d9f9b](f3d9f9b)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](#5084)) ([77954ab](77954ab)) ### Documentation * Parity circuit naming fixes ([#5076](#5076)) ([c255255](c255255)) </details> <details><summary>barretenberg: 0.26.6</summary> ## [0.26.6](barretenberg-v0.26.5...barretenberg-v0.26.6) (2024-03-08) ### Features * IPA documentation ([#4924](#4924)) ([48bd22e](48bd22e)) * Updating an SMT solver class ([#4981](#4981)) ([4b94d58](4b94d58)) ### Bug Fixes * Storage v2 ([#5027](#5027)) ([fe3190e](fe3190e)) * Update protogalaxy cmake dependencies ([#5066](#5066)) ([507c374](507c374)) ### Miscellaneous * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](#5065)) ([58e1ff4](58e1ff4)) * Cleanup of prover and verifier instances ([#4959](#4959)) ([f2fdefd](f2fdefd)) * Join-split example Part 1 ([#4965](#4965)) ([b9de0f5](b9de0f5)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](#5084)) ([77954ab](77954ab)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@aztec-package-v0.26.5...aztec-package-v0.26.6) (2024-03-08) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@barretenberg.js-v0.26.5...barretenberg.js-v0.26.6) (2024-03-08) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@aztec-cli-v0.26.5...aztec-cli-v0.26.6) (2024-03-08) ### Features * Show bytecode size per function in CLI inspect-contract ([#5059](AztecProtocol/aztec-packages#5059)) ([cb9fdc6](AztecProtocol/aztec-packages@cb9fdc6)) </details> <details><summary>aztec-packages: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@aztec-packages-v0.26.5...aztec-packages-v0.26.6) (2024-03-08) ### Features * Basic public reverts ([#4870](AztecProtocol/aztec-packages#4870)) ([5cccc78](AztecProtocol/aztec-packages@5cccc78)) * Deploying new inbox ([#5036](AztecProtocol/aztec-packages#5036)) ([fed729d](AztecProtocol/aztec-packages@fed729d)) * Detect unknown note type ids in compute_note_hash ([#5086](AztecProtocol/aztec-packages#5086)) ([6206bec](AztecProtocol/aztec-packages@6206bec)) * Easy deployment of protocol contracts in e2e ([#4983](AztecProtocol/aztec-packages#4983)) ([480161f](AztecProtocol/aztec-packages@480161f)) * IPA documentation ([#4924](AztecProtocol/aztec-packages#4924)) ([48bd22e](AztecProtocol/aztec-packages@48bd22e)) * Nullifier read requests in public kernel ([#4910](AztecProtocol/aztec-packages#4910)) ([0e44247](AztecProtocol/aztec-packages@0e44247)) * Show bytecode size per function in CLI inspect-contract ([#5059](AztecProtocol/aztec-packages#5059)) ([cb9fdc6](AztecProtocol/aztec-packages@cb9fdc6)) * Updating an SMT solver class ([#4981](AztecProtocol/aztec-packages#4981)) ([4b94d58](AztecProtocol/aztec-packages@4b94d58)) ### Bug Fixes * Canonical contract address ([#5030](AztecProtocol/aztec-packages#5030)) ([b2af880](AztecProtocol/aztec-packages@b2af880)) * Flaky deployment test ([#5035](AztecProtocol/aztec-packages#5035)) ([039eafc](AztecProtocol/aztec-packages@039eafc)) * Pull the correct platform image for noir ([#5097](AztecProtocol/aztec-packages#5097)) ([3342371](AztecProtocol/aztec-packages@3342371)) * Sleep function memory leak ([#5023](AztecProtocol/aztec-packages#5023)) ([a72cfea](AztecProtocol/aztec-packages@a72cfea)), closes [#4817](AztecProtocol/aztec-packages#4817) * Storage v2 ([#5027](AztecProtocol/aztec-packages#5027)) ([fe3190e](AztecProtocol/aztec-packages@fe3190e)) * Update protogalaxy cmake dependencies ([#5066](AztecProtocol/aztec-packages#5066)) ([507c374](AztecProtocol/aztec-packages@507c374)) ### Miscellaneous * Address warnings in noir test suite ([#4966](AztecProtocol/aztec-packages#4966)) ([7ef4ef5](AztecProtocol/aztec-packages@7ef4ef5)) * Bootstrap noir natively if nargo is invalid ([#5034](AztecProtocol/aztec-packages#5034)) ([df089de](AztecProtocol/aztec-packages@df089de)) * Build avm transpiler if we are on mac ([#5039](AztecProtocol/aztec-packages#5039)) ([c2966b9](AztecProtocol/aztec-packages@c2966b9)) * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](AztecProtocol/aztec-packages#5065)) ([58e1ff4](AztecProtocol/aztec-packages@58e1ff4)) * Cleanup of prover and verifier instances ([#4959](AztecProtocol/aztec-packages#4959)) ([f2fdefd](AztecProtocol/aztec-packages@f2fdefd)) * Delete bootstrap scripts from `noir/noir-repo` ([#5044](AztecProtocol/aztec-packages#5044)) ([add91ca](AztecProtocol/aztec-packages@add91ca)) * Disable `hello_world_example` noir test in aztec-packages CI ([#5061](AztecProtocol/aztec-packages#5061)) ([1be9243](AztecProtocol/aztec-packages@1be9243)) * Join-split example Part 1 ([#4965](AztecProtocol/aztec-packages#4965)) ([b9de0f5](AztecProtocol/aztec-packages@b9de0f5)) * Moving RootRollupInputs impl ([#5087](AztecProtocol/aztec-packages#5087)) ([f3d9f9b](AztecProtocol/aztec-packages@f3d9f9b)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](AztecProtocol/aztec-packages#5084)) ([77954ab](AztecProtocol/aztec-packages@77954ab)) ### Documentation * Parity circuit naming fixes ([#5076](AztecProtocol/aztec-packages#5076)) ([c255255](AztecProtocol/aztec-packages@c255255)) </details> <details><summary>barretenberg: 0.26.6</summary> ## [0.26.6](AztecProtocol/aztec-packages@barretenberg-v0.26.5...barretenberg-v0.26.6) (2024-03-08) ### Features * IPA documentation ([#4924](AztecProtocol/aztec-packages#4924)) ([48bd22e](AztecProtocol/aztec-packages@48bd22e)) * Updating an SMT solver class ([#4981](AztecProtocol/aztec-packages#4981)) ([4b94d58](AztecProtocol/aztec-packages@4b94d58)) ### Bug Fixes * Storage v2 ([#5027](AztecProtocol/aztec-packages#5027)) ([fe3190e](AztecProtocol/aztec-packages@fe3190e)) * Update protogalaxy cmake dependencies ([#5066](AztecProtocol/aztec-packages#5066)) ([507c374](AztecProtocol/aztec-packages@507c374)) ### Miscellaneous * **ci:** Re-enable certain bb solidity ACIR tests ([#5065](AztecProtocol/aztec-packages#5065)) ([58e1ff4](AztecProtocol/aztec-packages@58e1ff4)) * Cleanup of prover and verifier instances ([#4959](AztecProtocol/aztec-packages#4959)) ([f2fdefd](AztecProtocol/aztec-packages@f2fdefd)) * Join-split example Part 1 ([#4965](AztecProtocol/aztec-packages#4965)) ([b9de0f5](AztecProtocol/aztec-packages@b9de0f5)) * Remove eccvm functionality to update the op queue and ensure ultra ops are populated through function ([#5084](AztecProtocol/aztec-packages#5084)) ([77954ab](AztecProtocol/aztec-packages@77954ab)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Sarkoxed added 2 commits March 6, 2024 12:09

Update SMT solver class

f47601f

Added - new options to cvc5 solver config - `default_solver_config` constant so you don't need to initialize it each time - `print_assertions` method that converts smt lang to something more readable - tests for solver class

Updated terms

6e04b7d

- Changed `^` opeartor in FFITerm since it's not compatible with integers - Changed `!=` operator so it now uses boolean not instead of `== false` - Updated `std::string` method, so it now uses my new `stringify_term` function - Added `!` operator to symbolic Bool class

Sarkoxed requested a review from Rumata888 March 6, 2024 12:24

Sarkoxed added crypto cryptography product-security PRs extending our security mechanisms labels Mar 6, 2024

Rumata888 marked this pull request as ready for review March 6, 2024 13:47

Rumata888 reviewed Mar 6, 2024

View reviewed changes

barretenberg/cpp/src/barretenberg/smt_verification/solver/solver.cpp Outdated Show resolved Hide resolved

Rumata888 reviewed Mar 6, 2024

View reviewed changes

Fix typo and force CI to work

75ca0ee

Rumata888 approved these changes Mar 6, 2024

View reviewed changes

Sarkoxed and others added 3 commits March 8, 2024 14:07

Adding comments on cvc5 options in Solver class

6c15f2d

Merge branch 'master' into as/smt-update-solver-class

4773299

formatted

ae1880f

Sarkoxed merged commit 4b94d58 into master Mar 8, 2024
96 checks passed

Sarkoxed deleted the as/smt-update-solver-class branch March 8, 2024 15:28

AztecBot mentioned this pull request Mar 8, 2024

chore(master): Release 0.26.6 #5037

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Updating an SMT solver class #4981

feat: Updating an SMT solver class #4981

Sarkoxed commented Mar 6, 2024

Rumata888 Mar 6, 2024

Rumata888 Mar 6, 2024

Rumata888 left a comment

AztecBot commented Mar 6, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

feat: Updating an SMT solver class #4981

feat: Updating an SMT solver class #4981

Conversation

Sarkoxed commented Mar 6, 2024

Rumata888 Mar 6, 2024

Choose a reason for hiding this comment

Rumata888 Mar 6, 2024

Choose a reason for hiding this comment

Rumata888 left a comment

Choose a reason for hiding this comment

AztecBot commented Mar 6, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

AztecBot commented Mar 6, 2024 •

edited

Loading