Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #5064

Closed
wants to merge 1 commit into from
Closed

feat: Sync from noir #5064

wants to merge 1 commit into from

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Mar 7, 2024

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: add regression test for issue 4449 (noir-lang/noir#4503)
chore: pass macro processors by reference (noir-lang/noir#4501)
chore: bump bb to 0.26.3 (noir-lang/noir#4488)
fix: handling of gh deps in noir_wasm (noir-lang/noir#4499)
fix: iterative flattening pass (noir-lang/noir#4492)
chore: Move templated code for assert_message into the stdlib (noir-lang/noir#4475)
chore: pull out separate function for compiling and running a test
chore: update cargo deny config (noir-lang/noir#4486)
feat: run tests in parallel in nargo test (noir-lang/noir#4484)
END_COMMIT_OVERRIDE

…#4503)

chore: pass macro processors by reference (noir-lang/noir#4501)
chore: bump bb to 0.26.3 (noir-lang/noir#4488)
fix: handling of gh deps in noir_wasm (noir-lang/noir#4499)
fix: iterative flattening pass (noir-lang/noir#4492)
chore: Move templated code for assert_message into the stdlib (noir-lang/noir#4475)
chore: pull out separate function for compiling and running a test
chore: update cargo deny config (noir-lang/noir#4486)
feat: run tests in parallel in `nargo test`  (noir-lang/noir#4484)
@ludamad ludamad closed this Mar 7, 2024
@ludamad ludamad mentioned this pull request Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Changes to circuit sizes

Generated at commit: 1531ba516734251207c00cacbedb9d593784003f, compared to commit: fed729daaa667b78e9291a9eae5ab8225f82d572

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init +2,221 ❌ +4.69% +2,221 ❌ +0.62%
rollup_base +10,497 ❌ +6.49% +10,497 ❌ +0.61%
private_kernel_inner +2,224 ❌ +2.35% +2,224 ❌ +0.42%
public_kernel_app_logic +582 ❌ +1.08% +582 ❌ +0.19%
public_kernel_setup +191 ❌ +0.71% +191 ❌ +0.11%
public_kernel_teardown +191 ❌ +0.67% +191 ❌ +0.11%
private_kernel_tail +328 ❌ +0.09% +328 ❌ +0.04%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init 49,528 (+2,221) +4.69% 359,331 (+2,221) +0.62%
rollup_base 172,123 (+10,497) +6.49% 1,744,091 (+10,497) +0.61%
private_kernel_inner 96,866 (+2,224) +2.35% 531,002 (+2,224) +0.42%
public_kernel_app_logic 54,569 (+582) +1.08% 308,675 (+582) +0.19%
public_kernel_setup 26,907 (+191) +0.71% 176,935 (+191) +0.11%
public_kernel_teardown 28,608 (+191) +0.67% 178,637 (+191) +0.11%
private_kernel_tail 373,493 (+328) +0.09% 839,611 (+328) +0.04%

@AztecBot
Copy link
Collaborator Author

AztecBot commented Mar 7, 2024

Benchmark results

Metrics with a significant change:

  • circuit_simulation_time_in_ms (base-rollup): 1,321 (+103%)
  • circuit_simulation_time_in_ms (merge-rollup): 5.71 (-32%)
  • tx_sequencer_processing_time_ms (0): 0.0272 (-100%)
  • l2_block_building_time_in_ms (8): 16,338 (+51%)
  • l2_block_building_time_in_ms (32): 65,318 (+52%)
  • l2_block_building_time_in_ms (64): 130,705 (+53%)
  • l2_block_rollup_simulation_time_in_ms (8): 12,445 (+75%)
  • l2_block_rollup_simulation_time_in_ms (32): 49,463 (+73%)
  • l2_block_rollup_simulation_time_in_ms (64): 99,648 (+77%)
  • l1_rollup_execution_gas (8): 194,104 (-71%)
  • l1_rollup_execution_gas (32): 500,126 (-49%)
  • l1_rollup_execution_gas (64): 908,526 (-35%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit fed729da and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 5,700 18,884 36,452
l1_rollup_calldata_gas 66,156 238,820 469,268
l1_rollup_execution_gas ⚠️ 194,104 (-71%) ⚠️ 500,126 (-49%) ⚠️ 908,526 (-35%)
l2_block_processing_time_in_ms 1,181 (+2%) 4,463 (+3%) 8,866 (+4%)
note_successful_decrypting_time_in_ms 199 (+1%) 539 (+3%) 990 (+4%)
note_trial_decrypting_time_in_ms 107 (-2%) 58.8 (+45%) 124 (+47%)
l2_block_building_time_in_ms ⚠️ 16,338 (+51%) ⚠️ 65,318 (+52%) ⚠️ 130,705 (+53%)
l2_block_rollup_simulation_time_in_ms ⚠️ 12,445 (+75%) ⚠️ 49,463 (+73%) ⚠️ 99,648 (+77%)
l2_block_public_tx_process_time_in_ms 3,864 (+4%) 15,614 (+9%) 30,896 (+6%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 13,933 (-3%) 26,900 (-1%)
note_history_successful_decrypting_time_in_ms 1,242 2,436 (+2%)
note_history_trial_decrypting_time_in_ms 89.1 (-9%) 142 (+38%)
node_database_size_in_bytes 18,776,144 35,541,072
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 252 (+2%) 44,736 28,001
private-kernel-ordering 193 (+1%) 52,625 14,627
base-rollup ⚠️ 1,321 (+103%) 177,932 933 (-6%)
root-rollup 70.0 (+3%) 4,192 (-3%) 825
private-kernel-inner 322 (+3%) 73,715 28,001
public-kernel-app-logic 196 (+21%) 32,254 25,379
merge-rollup ⚠️ 5.71 (-32%) 2,712 (-5%) 933 (-6%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves
batch_insert_into_append_only_tree_16_depth_ms 9.85 (-1%) 11.0 (+10%) 12.4 (+3%) 16.2 (+1%) 22.1 (+4%) 35.1 (+4%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 79.0 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.572 (-1%) 0.611 (+10%) 0.528 (+3%) 0.502 (+1%) 0.464 (+4%) 0.438 (+4%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 45.7 (+1%) 72.2 (+1%) 231 (+4%) 443 (-1%) 865 (+3%) 1,715 (+4%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 96.0 159 543 1,055 2,079 4,127
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.469 (+1%) 0.446 (+1%) 0.422 (+4%) 0.415 (-1%) 0.413 (+3%) 0.412 (+4%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 53.7 (+1%) 107 (+2%) 339 (+5%) 661 1,309 (+3%) 2,598 (+3%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 104 207 691 1,363 2,707 5,395
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.478 (+1%) 0.481 (+1%) 0.459 (+4%) 0.454 (-1%) 0.454 (+3%) 0.452 (+3%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A 61.0 (+1%) N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A 109 N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A 0.534 (+1%) N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts
tx_size_in_bytes 19,179

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms 2,584 (-2%) 1,376 (+2%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms ⚠️ 0.0272 (-100%) 479 (+5%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants