chore: add note to pack arguments

[Maddiaa0]

Please read contributing guidelines and remove this line.

[Maddiaa0]

• chore: add note to pack arguments #5304 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on Graphite

[fcarreiro]

Thanks! We will still have to discuss this in a bit more detail ;)

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 31.4 (+115%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit c0a1abf3 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,820	36,356
l1_rollup_calldata_gas	66,400	239,092	468,344
l1_rollup_execution_gas	647,498	929,450	1,304,524
l2_block_processing_time_in_ms	1,323 (-12%)	4,989 (+6%)	9,192 (+1%)
note_successful_decrypting_time_in_ms	226 (+8%)	527	951 (-3%)
note_trial_decrypting_time_in_ms	⚠️ 31.4 (+115%)	46.1 (-3%)	83.1 (-29%)
l2_block_building_time_in_ms	18,268 (+1%)	68,375	135,411 (-1%)
l2_block_rollup_simulation_time_in_ms	8,071	28,487 (-1%)	55,985 (-2%)
l2_block_public_tx_process_time_in_ms	10,176 (+2%)	39,832	79,328

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,127 (-6%)	26,175 (-5%)
note_history_successful_decrypting_time_in_ms	1,259 (+4%)	2,431 (-1%)
note_history_trial_decrypting_time_in_ms	95.3 (+48%)	138 (-10%)
node_database_size_in_bytes	19,038,288	35,672,144
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	286	44,366	28,244
private-kernel-ordering	215	52,868	14,326
base-parity	1,788 (-1%)	128	311
base-rollup	713 (-1%)	165,787	925
root-parity	1,555 (-2%)	1,244	311
root-rollup	63.3 (+1%)	4,487	789
private-kernel-inner	645	73,771	28,244
public-kernel-app-logic	450 (+1%)	35,260	28,215
public-kernel-tail	173	40,926	28,215
merge-rollup	8.28 (-1%)	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1	15.9 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.587	0.493 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.0 (+1%)	71.9 (-1%)	230 (-1%)	445	869	1,708 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.473 (+1%)	0.444 (-1%)	0.419 (-1%)	0.416	0.413	0.410 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.8	107	334 (-1%)	660	1,300 (-1%)	2,586 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.481 (+1%)	0.481	0.455 (-1%)	0.455	0.452 (-1%)	0.451 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.5 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.539 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,012

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,266 (+2%)	1,743 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	10.4 (-12%)	1,252 (+1%)